starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #938] [MERGED] Fix API break: public API must not expose JsonElement objects #1370

New Issue
Open
opened 2026-01-29 17:00:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:00:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/938
Author: @softworkz
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/17/2025
Merged by: @FlorianRappl

Base: develop ← Head: submit_ipc_types

📝 Commits (3)

  • 8ff8754 Fix API break: public API must not expose JsonElement objects
  • b89c08e IpcMainTests: Properly test for the types of values (must not be JsonElement)
  • be518a7 IpcMain: Properly handle Ipc message params (always 2-elem array)

📊 Changes

4 files changed (+183 additions, -46 deletions)

View changed files

📝 src/ElectronNET.API/API/IpcMain.cs (+37 -43)
➕ src/ElectronNET.API/Serialization/JsonToBoxedPrimitivesConverter.cs (+126 -0)
📝 src/ElectronNET.IntegrationTests/ElectronNET.IntegrationTests.csproj (+1 -1)
📝 src/ElectronNET.IntegrationTests/Tests/IpcMainTests.cs (+19 -2)

📄 Description

This changes deserialization to the way how it was with
Json.Net: Only .net primitive types are exposed publicly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/938 **Author:** [@softworkz](https://github.com/softworkz) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/17/2025 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `develop` ← **Head:** `submit_ipc_types` --- ### 📝 Commits (3) - [`8ff8754`](https://github.com/ElectronNET/Electron.NET/commit/8ff875435be8643d79b366bb0e7216cf40f5037e) Fix API break: public API must not expose JsonElement objects - [`b89c08e`](https://github.com/ElectronNET/Electron.NET/commit/b89c08ee9677855c4457ad1e9ebbebbd47cd05b8) IpcMainTests: Properly test for the types of values (must not be JsonElement) - [`be518a7`](https://github.com/ElectronNET/Electron.NET/commit/be518a7a10e61de001601b900f841fb8587ddc8a) IpcMain: Properly handle Ipc message params (always 2-elem array) ### 📊 Changes **4 files changed** (+183 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.API/API/IpcMain.cs` (+37 -43) ➕ `src/ElectronNET.API/Serialization/JsonToBoxedPrimitivesConverter.cs` (+126 -0) 📝 `src/ElectronNET.IntegrationTests/ElectronNET.IntegrationTests.csproj` (+1 -1) 📝 `src/ElectronNET.IntegrationTests/Tests/IpcMainTests.cs` (+19 -2) </details> ### 📄 Description This changes deserialization to the way how it was with Json.Net: Only .net primitive types are exposed publicly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:00:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?