starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-04 05:34:51 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #939] [MERGED] Cleanup & Consistency #1373

New Issue
Open
opened 2026-01-29 17:00:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:00:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/939
Author: @softworkz
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/17/2025
Merged by: @FlorianRappl

Base: develop ← Head: submit_cleanup

📝 Commits (4)

  • 5f6e4a9 Disable Nullable for all projects (was already for API/AspNet)
  • 9e9558b SocketIoFacade: Remove unused method
  • 2e5c620 ShowItemInFolderAsync: Fix endless hang
  • 55c0353 Use non-generic TaskCompletionSource where applicable

📊 Changes

8 files changed (+24 additions, -41 deletions)

View changed files

📝 src/ElectronNET.API/API/Dialog.cs (+2 -2)
📝 src/ElectronNET.API/API/Session.cs (+14 -14)
📝 src/ElectronNET.API/API/Shell.cs (+1 -5)
📝 src/ElectronNET.API/API/WebContents.cs (+2 -2)
📝 src/ElectronNET.API/Bridge/SocketIOFacade.cs (+2 -18)
📝 src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj (+1 -0)
📝 src/ElectronNET.WebApp/ElectronNET.WebApp.csproj (+1 -0)
📝 src/ElectronNET/ElectronNET.csproj (+1 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/939 **Author:** [@softworkz](https://github.com/softworkz) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/17/2025 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `develop` ← **Head:** `submit_cleanup` --- ### 📝 Commits (4) - [`5f6e4a9`](https://github.com/ElectronNET/Electron.NET/commit/5f6e4a9e9d6756cd7648745fec51e0cc4f0ed13f) Disable Nullable for all projects (was already for API/AspNet) - [`9e9558b`](https://github.com/ElectronNET/Electron.NET/commit/9e9558b837bd28e4e1b77d41e5caf39ed1a0ebd6) SocketIoFacade: Remove unused method - [`2e5c620`](https://github.com/ElectronNET/Electron.NET/commit/2e5c6200a64a80bb66c8fd64d9c761499a3a94d3) ShowItemInFolderAsync: Fix endless hang - [`55c0353`](https://github.com/ElectronNET/Electron.NET/commit/55c035323bebeac03dffe648bdad62c6d44d6ec2) Use non-generic TaskCompletionSource where applicable ### 📊 Changes **8 files changed** (+24 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.API/API/Dialog.cs` (+2 -2) 📝 `src/ElectronNET.API/API/Session.cs` (+14 -14) 📝 `src/ElectronNET.API/API/Shell.cs` (+1 -5) 📝 `src/ElectronNET.API/API/WebContents.cs` (+2 -2) 📝 `src/ElectronNET.API/Bridge/SocketIOFacade.cs` (+2 -18) 📝 `src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj` (+1 -0) 📝 `src/ElectronNET.WebApp/ElectronNET.WebApp.csproj` (+1 -0) 📝 `src/ElectronNET/ElectronNET.csproj` (+1 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:00:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1373
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?