Help diagnose package.json not picked up #208

Closed
opened 2026-01-29 16:33:49 +00:00 by claunia · 2 comments
Owner

Originally created by @MartinKuhne on GitHub (Aug 28, 2018).

I have a VS project on 0.0.9. The file structure is \source\solutiondir\projectdir and the projectdir has both the client and API, as well as a package.json

My goal is to set 'build' properties as per https://github.com/electron-userland/electron-builder
In particular, I need to add a license file to be distributed with the project (using the extraFiles property)

I tried

  "build": {
    "artifactName": "beer.exe",

That wasn't picked up either

I ran procmon and I can see that package.json is being read.

I think I am on the wrong track here. What is the expected behaviour?

Thanks, Martin

Originally created by @MartinKuhne on GitHub (Aug 28, 2018). I have a VS project on 0.0.9. The file structure is \source\solutiondir\projectdir and the projectdir has both the client and API, as well as a package.json My goal is to set 'build' properties as per https://github.com/electron-userland/electron-builder In particular, I need to add a license file to be distributed with the project (using the extraFiles property) I tried ``` "build": { "artifactName": "beer.exe", ``` That wasn't picked up either I ran procmon and I can see that package.json is being read. I think I am on the wrong track here. What is the expected behaviour? Thanks, Martin
Author
Owner

@robertmuehsig commented on GitHub (Aug 28, 2018):

I think this is still on the ToDo list :-/ When I remember correctly we only invoke the electron builder via the command line and unfortunatly don't support the build file, See this line in the CLI project: https://github.com/ElectronNET/Electron.NET/blob/master/ElectronNET.CLI/Commands/BuildCommand.cs#L135

@robertmuehsig commented on GitHub (Aug 28, 2018): I think this is still on the ToDo list :-/ When I remember correctly we only invoke the electron builder via the command line and unfortunatly don't support the build file, See this line in the CLI project: https://github.com/ElectronNET/Electron.NET/blob/master/ElectronNET.CLI/Commands/BuildCommand.cs#L135
Author
Owner

@MartinKuhne commented on GitHub (Aug 28, 2018):

Thanks for the quick reply. I tried a CopyFile msbuild task, however it seems it clears out any existing files in the target folder, so that won't work. Finally, added a step on bamboo to add my license file

@MartinKuhne commented on GitHub (Aug 28, 2018): Thanks for the quick reply. I tried a CopyFile msbuild task, however it seems it clears out any existing files in the target folder, so that won't work. Finally, added a step on bamboo to add my license file
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#208