mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
Electronize Init SHOULD NOT depend on visual Studio file #45
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tebeco on GitHub (Nov 3, 2017).
Originally assigned to: @robertmuehsig on GitHub.
So i followed the step but never open Visual Studio, Only CLI and VsCode
Repro step :
Program.csStartup.cscsprojthe file not found is a file specific to Visual Studio (used by the Configuration ComboBox) allowing user to choose between IIS or Console etc ...
It the goal of Electron is to be XPlat, and Electron.Net too, that might be a got idea to get rid of dependencies over Visual Studio generated file right ?
@tebeco commented on GitHub (Nov 3, 2017):
As i saw from this code :
https://github.com/ElectronNET/Electron.NET/blob/master/ElectronNET.CLI/Commands/InitCommand.cs#L78
https://github.com/ElectronNET/Electron.NET/blob/master/ElectronNET.CLI/Commands/InitCommand.cs#L93-L109
@robertmuehsig commented on GitHub (Nov 3, 2017):
Ah - good catch! Sorry - I thought this file was present even when init it without Visual Studio.
First step would be to check if the file does exists do the manipulation - if not, do nothing.
As a second step I could do the same with the VSCode launch file - but because of the nature of VSCode this might be not super important.
@robertmuehsig commented on GitHub (Nov 3, 2017):
As a workaround you might create a launchSettings.json file yourself. The code is pretty stupid TBH ;)
@andymac4182 commented on GitHub (Nov 4, 2017):
It would be good if it created a
launchSettings.jsonfile so you can open it in VS later and the same debug experience will work.@Petermarcu commented on GitHub (Nov 4, 2017):
I just hit this too.
@Petermarcu commented on GitHub (Nov 4, 2017):
I opened an issue against ASP.NET as well to make it so the templates create the same assets whether through VS or CLI. https://github.com/aspnet/templating/issues/142
@Petermarcu commented on GitHub (Nov 4, 2017):
After creating launchSettings.json and then cleaning out the project entry and manifest from the initial failed run of
electronize initI am past this. Here is the initial launchSettings.json in case anyone wants to copy paste.@tebeco commented on GitHub (Nov 4, 2017):
dunno when i’ll have time to give it a shoot
if no file ?
@robertmuehsig commented on GitHub (Nov 4, 2017):
I'm on it 👍
@robertmuehsig commented on GitHub (Nov 4, 2017):
As a first step: If launchSetting is not present, do nothing. I'm not sure if it is clever to create the whole file.
@robertmuehsig commented on GitHub (Nov 4, 2017):
The fix will be part of 0.0.6. Current approach is: We only edit the file if it is present, because creating the file itself might result in strange issues as well.
@robertmuehsig commented on GitHub (Nov 5, 2017):
I released Version 0.0.6.
@tebeco commented on GitHub (Nov 14, 2017):
https://github.com/aspnet/docs/issues/4021#issuecomment-342325746
is it interessting ?