mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-04 05:34:51 +00:00
Build process for 8.31.1 no longer produces a self-contained app #485
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @robalexclark on GitHub (May 9, 2020).
Originally assigned to: @GregorBiswanger on GitHub.
There was a change from version 7.30.2 to 8.31.1 to the file ElectronNET.CLI/Commands/BuildCommand.cs where --no-self-contained is now specified.
Previously this was not specified so a self-contained app was produced, but this change means that the dotnet core runtime needs to be manually installed on all target machines. Is this by design?
If it is by design then could you allow --self-contained true/false option to be specified to electronize build please?
@ThuCommix commented on GitHub (May 9, 2020):
I think it would be better if we could specify the dotnet publish arguments by ourselfs.
@GregorBiswanger commented on GitHub (May 9, 2020):
That was an accident and will be fixed in the upcoming version 8.31.2.
@ThuCommix A "no" self contained doesn't really make sense for a portable cross platform solution .. I would like to have it active by default ..
@GregorBiswanger commented on GitHub (May 9, 2020):
Duplicate of #387