mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
Upgrade Electron to Version 11 #593
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @scottkuhl on GitHub (Nov 21, 2020).
Originally assigned to: @GregorBiswanger on GitHub.
Upgrade the version of Electron that Electron.NET is using from 9 to 11.
@scottkuhl commented on GitHub (Nov 21, 2020):
I started a POC here: https://github.com/scottkuhl/Electron.NET/tree/poc/upgrade-to-electron-11
That repo updates all NPM packages to the latest along with Electron to v11. It looks like there is one breaking change that will affect Electron.NET: https://github.com/electron/electron/pull/23578 The id property has been removed from BrowserView.
@GregorBiswanger , @robertmuehsig
I don't see anywhere this code is used on the web app for testing. And since there are no automated tests, how do you normally go about testing these kinds of changes?
@GregorBiswanger commented on GitHub (Nov 21, 2020):
Our next update will support Electron 11 + .NET 5.
@scottkuhl commented on GitHub (Nov 21, 2020):
@GregorBiswanger
I have a PR in for .NET 5 and I'm working on the Electron upgrade to 11 in the linked repo above. Should I just hold off and wait?
@GregorBiswanger commented on GitHub (Nov 21, 2020):
Oh no, that´s perfect! I will definitely prefer your PR... because we only have time for the big update at the beginning of December...