mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
Need the ability to use npm ci and a package-lock file. #621
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Delpire on GitHub (Jan 21, 2021).
Originally assigned to: @GregorBiswanger on GitHub.
I believe it is a good practice to use the
npm cicommand when building from your continuous integration pipeline.https://docs.npmjs.com/cli/v6/commands/npm-ci
My understanding is that one major benefit is that it will fail builds if the package.json does not match the package-lock.json file. This is important when you want to keep track of your dependencies, especially for security audits as well as ensuring you are following license agreements correctly.
This brings me to the second aspect of this feature, which is that we should be using a package-lock file and checking it into our source control. There are messages about this during the build, and it is what is recommended by npm. Currently there does not seem to be any way to tell Electron .NET about a package-lock.json.
I believe the Electron .NET CLI tool, especially the build command, should have a flag to specify using
npm cirather thannpm installand we should have an argument similar to/package-jsonbut for the package-lock.json instead. Currently if you pass the package lock into/package-json, the build fails.