mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-04 05:34:51 +00:00
electronize doesn't add version or description to the package.json it uses in a build.
#636
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @danatcofo on GitHub (Feb 18, 2021).
Originally assigned to: @GregorBiswanger on GitHub.
Using the latest version (11.5.1)
This is causing a build error for linux targets with a message of
Please specify 'version' in the package.jsonand also causes a warning with message ofdescription is missed in the package.jsonSteps to Reproduce:
electronize /target linuxon a linux system (other steps may need to be done here to get linux building correctly)the file used during the electronize call is put in this general location
~/obj/desktop/-encodedCommand/package.json@GregorBiswanger commented on GitHub (Feb 18, 2021):
Since version 8.31.1 we have a feature to set the name and author of the app in
electron.manifest.json.Already tried?
@danatcofo commented on GitHub (Feb 18, 2021):
that is set just fine, its not the name and the author that is causing any issues, its version/description.
I noticed that name/author was in the output package.json already but didn't comment on it. Honestly I think something changed upstream of us that is now causing electronize to fail on a linux target where it did not before. It exposed something electronize should probably do but isn't.
this is the output of the electronize package.json
something that stand out here... version, description, repository all should be overridable. possibly license as well.
@BenjaminVettori commented on GitHub (Feb 25, 2021):
It seems that name, author and version are only written to package.json and package-lock.json, if the "buildVersion" value is set: https://github.com/ElectronNET/Electron.NET/blob/master/ElectronNET.Host/build-helper.js
electron.manifest.json:
@nakibulshaki commented on GitHub (Aug 30, 2022):
I need to add build version like "1.0.0.9"
but shows 'Invalid version: "1.0.0.9" failedTask=build stackTrace=Error: Invalid version: "1.0.0.9"'
But when i try "1.0.9" it's works fine
@BenjaminVettori commented on GitHub (Sep 5, 2022):
That error appears probably because the package.json version which is set by electron.net needs to be in semantic version format. You can find more about semantic versioning at semver and npmjs
@GregorBiswanger commented on GitHub (Mar 28, 2023):
🎉🚀 New Electron.NET version 23.6.1 released 🚀🎉
With native Electron 23 and .NET 6 support. Your problem should be fixed here. If you continue to have the problem, please let us know. Please note the correct updating of your API & CLI. Info in the README. Have fun!