starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

Version flag not persisting with the referenced executable #678

New Issue
Closed
opened 2026-01-29 16:45:47 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 16:45:47 +00:00
Owner
Copy Link

Originally created by @tub5 on GitHub (Jul 2, 2021).

Originally assigned to: @GregorBiswanger on GitHub.

When using the new Version flag, this is not being persisted to the dotnet command (I'm not sure why this wasn't in the PR).
You can bypass this by using electronize build /target win /Version 2.0.13 /p:Version=2.0.13 /p:ProductVersion=2.0.13 however, this should not have to be the case.

  • Version: 13.5.1
  • Target: Windows

Steps to Reproduce:

  1. use the /Version flag when building the electronize build command
Originally created by @tub5 on GitHub (Jul 2, 2021). Originally assigned to: @GregorBiswanger on GitHub. <!-- Please search existing issues to avoid creating duplicates. --> When using the new Version flag, this is not being persisted to the dotnet command (I'm not sure why this wasn't in the PR). You can bypass this by using `electronize build /target win /Version 2.0.13 /p:Version=2.0.13 /p:ProductVersion=2.0.13` however, this should not have to be the case. <!-- Which version of Electron.NET CLI and API are you using? --> <!-- Please always try to use latest version before report. --> * **Version**: 13.5.1 <!-- Which version of .NET Core and Node.js are you using (if applicable)? --> <!-- What target are you building for? --> * **Target**: Windows <!-- Enter your issue details below this comment. --> <!-- If you want, you can donate to increase issue priority (https://donorbox.org/electron-net) --> Steps to Reproduce: 1. use the `/Version` flag when building the `electronize build` command
claunia added the bug label 2026-01-29 16:45:47 +00:00
claunia commented 2026-01-29 16:45:49 +00:00
Author
Owner
Copy Link

@GregorBiswanger commented on GitHub (Jul 2, 2021):

Would you like to quickly submit a pull request? :)

Then it should still be fixed for the 13.5.1 release.

@GregorBiswanger commented on GitHub (Jul 2, 2021): Would you like to quickly submit a pull request? :) Then it should still be fixed for the 13.5.1 release.
claunia commented 2026-01-29 16:45:50 +00:00
Author
Owner
Copy Link

@tub5 commented on GitHub (Jul 2, 2021):

@GregorBiswanger I'm just testing it now. Will submit within half an hour.

@tub5 commented on GitHub (Jul 2, 2021): @GregorBiswanger I'm just testing it now. Will submit within half an hour.
claunia commented 2026-01-29 16:45:51 +00:00
Author
Owner
Copy Link

@tub5 commented on GitHub (Jul 2, 2021):

@GregorBiswanger PR in

@tub5 commented on GitHub (Jul 2, 2021): @GregorBiswanger PR in
claunia commented 2026-01-29 16:45:51 +00:00
Author
Owner
Copy Link

@tub5 commented on GitHub (Jul 2, 2021):

Permission to stop hyperventilating now 😂

@tub5 commented on GitHub (Jul 2, 2021): Permission to stop hyperventilating now 😂
claunia commented 2026-01-29 16:45:52 +00:00
Author
Owner
Copy Link

@GregorBiswanger commented on GitHub (Jul 2, 2021):

yes you can run down the adrenaline now... 😂😂😂🥳

Thank you for your support!

@GregorBiswanger commented on GitHub (Jul 2, 2021): yes you can run down the adrenaline now... 😂😂😂🥳 Thank you for your support!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?