mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
dotnet electronize start should abort if build fails #68
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yoDon on GitHub (Nov 12, 2017).
Originally assigned to: @robertmuehsig on GitHub.
Hi guys, at least in VS Code if there is a compiler error during the dotnet electronize start's build step, there are still enough old built *.exe's lying around that the electron app will appear to launch and run, but it's running the last successful build not the current code. Definitely a recipe for burning a ton of extra time debugging the wrong exe, and trying to remember to either manually clean bin and obj before each build or manually doing an explicit build step (which spews less into the terminal window) before running start. Having start abort if the build fails would be a huge help.
@robertmuehsig commented on GitHub (Nov 15, 2017):
The build/start command will now stop if the publish command fails (e.g. compilation error occured) - maybe not perfect, but should be better then now.
@robertmuehsig commented on GitHub (Nov 15, 2017):
mhh... i broke it...
@robertmuehsig commented on GitHub (Nov 15, 2017):
Not perfect, but could work. The code now searchs for "error". It would be way cleaner to get the exit code of the actual cmd.exe/bash, but I couldn't get it and the actual cmd.exe runs fine...