starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

.NET code no longer compiles after PR merge. #998

New Issue
Closed
opened 2026-01-29 16:54:10 +00:00 by claunia · 9 comments
claunia commented 2026-01-29 16:54:10 +00:00
Owner
Copy Link

Originally created by @agracio on GitHub (Nov 4, 2025).

https://github.com/ElectronNET/Electron.NET/pull/893 was merged into main however it appears something went wrong and the code in main no longer compiles.

develop branch also no longer compiles with different exception than main.

PR origin https://github.com/softworkz/ElectronNET/tree/electronnet_core works perfectly fine.

Originally created by @agracio on GitHub (Nov 4, 2025). https://github.com/ElectronNET/Electron.NET/pull/893 was merged into main however it appears something went wrong and the code in main no longer compiles. `develop` branch also no longer compiles with different exception than `main`. PR origin https://github.com/softworkz/ElectronNET/tree/electronnet_core works perfectly fine.
claunia added the bug label 2026-01-29 16:54:10 +00:00
claunia commented 2026-01-29 16:54:11 +00:00
Author
Owner
Copy Link

@FlorianRappl commented on GitHub (Nov 4, 2025):

Yes, the Process class has been updated and brought back. It was one of the classes missing in the referenced origin.

@FlorianRappl commented on GitHub (Nov 4, 2025): Yes, the `Process` class has been updated and brought back. It was one of the classes missing in the referenced origin.
claunia commented 2026-01-29 16:54:12 +00:00
Author
Owner
Copy Link

@agracio commented on GitHub (Nov 4, 2025):

@FlorianRappl not sure why you closed it as completed, current code in main does not compile. Is there a pending PR to fix it?

I performed fresh checkouts on both main and develop branches just in case there were some merge issues.

@agracio commented on GitHub (Nov 4, 2025): @FlorianRappl not sure why you closed it as completed, current code in main does not compile. Is there a pending PR to fix it? I performed fresh checkouts on both `main` and `develop` branches just in case there were some merge issues.
claunia commented 2026-01-29 16:54:13 +00:00
Author
Owner
Copy Link

@FlorianRappl commented on GitHub (Nov 4, 2025):

  1. main is the release branch. There is no release for the 0.1.0 yet. Right now its a preview.
  2. develop works - if in doubt look at the action

In general build failures are not for the issue tracker (esp. labelled as "bugs", which are issues with the lib - a build failure does not trigger a build). So a bit odd to open a bug for it - but at least it acted as a reminder.

@FlorianRappl commented on GitHub (Nov 4, 2025): 1. `main` is the release branch. There is no release for the 0.1.0 yet. Right now its a [preview](https://github.com/ElectronNET/Electron.NET/releases/tag/0.1.0-pre.139). 2. `develop` works - if in doubt look at the [action](https://github.com/ElectronNET/Electron.NET/actions/runs/19075476605) In general build failures are not for the issue tracker (esp. labelled as "bugs", which are issues with the lib - a build failure does not trigger a build). So a bit odd to open a bug for it - but at least it acted as a reminder.
claunia commented 2026-01-29 16:54:13 +00:00
Author
Owner
Copy Link

@agracio commented on GitHub (Nov 4, 2025):

  1. This is my mistake as I though that final changes have been merged from develop to main.
  2. It appears there is a fresh commit to develop - it was failing when I opened this issue.

Yes a 'bug' might have been a mistake but as for issue tracker it does make sense to open an issue if there is a problem with the code. Thank you for taking care of the compile error.

@agracio commented on GitHub (Nov 4, 2025): 1. This is my mistake as I though that final changes have been merged from develop to main. 2. It appears there is a fresh commit to `develop` - it was failing when I opened this issue. Yes a 'bug' might have been a mistake but as for issue tracker it does make sense to open an issue if there is a problem with the code. Thank you for taking care of the compile error.
claunia commented 2026-01-29 16:54:14 +00:00
Author
Owner
Copy Link

@FlorianRappl commented on GitHub (Nov 4, 2025):

It appears there is a fresh commit to develop - it was failing when I opened this issue.

Yes I know. But when I closed it the build was running again. (2) was a response to your last comment, not the OP.

@FlorianRappl commented on GitHub (Nov 4, 2025): > It appears there is a fresh commit to develop - it was failing when I opened this issue. Yes I know. But when I closed it the build was running again. (2) was a response to your last comment, not the OP.
claunia commented 2026-01-29 16:54:15 +00:00
Author
Owner
Copy Link

@agracio commented on GitHub (Nov 4, 2025):

What is the current status of develop branch, I mentioned in another issue that the code can benefit from refactoring shaving 1.5k-2k lines of code, but do not want to make changes while the branch is still unstable should I wait for a merge to main first?

@agracio commented on GitHub (Nov 4, 2025): What is the current status of `develop` branch, I mentioned in another issue that the code can benefit from refactoring shaving 1.5k-2k lines of code, but do not want to make changes while the branch is still unstable should I wait for a merge to main first?
claunia commented 2026-01-29 16:54:16 +00:00
Author
Owner
Copy Link

@FlorianRappl commented on GitHub (Nov 4, 2025):

You can always make a PR.

Target for any PRs should be develop.

@FlorianRappl commented on GitHub (Nov 4, 2025): You can always make a PR. Target for any PRs should be `develop`.
claunia commented 2026-01-29 16:54:16 +00:00
Author
Owner
Copy Link

@agracio commented on GitHub (Nov 4, 2025):

Unfortunately develop branch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies.
This results in solution build errors and inability to launch local test app.

I was able to resolve issue locally by updating ElectronNET.Core and ElectronNET.Core.AspNet nuget package references to 0.0.18.

PR https://github.com/ElectronNET/Electron.NET/pull/904

@agracio commented on GitHub (Nov 4, 2025): Unfortunately `develop` branch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies. This results in solution build errors and inability to launch local test app. I was able to resolve issue locally by updating ElectronNET.Core and ElectronNET.Core.AspNet nuget package references to 0.0.18. PR https://github.com/ElectronNET/Electron.NET/pull/904
claunia commented 2026-01-29 16:54:17 +00:00
Author
Owner
Copy Link

@FlorianRappl commented on GitHub (Nov 4, 2025):

Unfortunately develop branch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies.

Nope - they are set to what main will be. For these projects you should always either change locally or use main.

@FlorianRappl commented on GitHub (Nov 4, 2025): > Unfortunately develop branch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies. Nope - they are set to what `main` will be. For these projects you should always either change locally or use `main`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?