starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[python] fix subprocess shell pipeline

Browse Source
This commit is contained in:
Cosimo Lupo
2015-03-22 00:15:54 +00:00
parent 064d8e0bea
commit 203fe326d4
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
python/tests/compatibility_test.py
View File

@@ -47,9 +47,10 @@ for filename in INPUTS.splitlines():
if diff_q(uncompressed, expected) != 0:
sys.exit(1)
# Test the streaming version
p = Popen('"%s" -d > "%s"' % (BRO, uncompressed), shell=True, stdin=PIPE)
with open(filename, "rb") as infile:
data = infile.read()
p.communicate(data)
p = Popen('"%s" -d' % BRO, stdin=infile, stdout=PIPE, shell=True)
output = p.communicate()[0]
with open(uncompressed, "wb") as outfile:
outfile.write(output)
if diff_q(uncompressed, expected) != 0:
sys.exit(1)

12
python/tests/roundtrip_test.py
View File

@@ -33,16 +33,18 @@ for filename in INPUTS.splitlines():
print('Roundtrip testing of file "%s"' % os.path.basename(filename))
compressed = os.path.splitext(filename)[0] + ".bro"
uncompressed = os.path.splitext(filename)[0] + ".unbro"
with open(filename, "rb") as infile:
data = infile.read()
call('"%s" -f -i "%s" -o "%s"' % (BRO, filename, compressed), shell=True)
call('"%s" -f -d -i "%s" -o "%s"' %
(BRO, compressed, uncompressed), shell=True)
if diff_q(filename, uncompressed) != 0:
sys.exit(1)
# Test the streaming version
p = Popen("%s | %s -d > %s" % (BRO, BRO, uncompressed), stdin=PIPE,
shell=True)
p.communicate(data)
with open(filename, "rb") as infile:
p1 = Popen(BRO, stdin=infile, stdout=PIPE, shell=True)
p2 = Popen("%s -d" % BRO, stdin=p1.stdout, stdout=PIPE, shell=True)
p1.stdout.close()
output = p2.communicate()[0]
with open(uncompressed, "wb") as outfile:
outfile.write(output)
if diff_q(filename, uncompressed) != 0:
sys.exit(1)