[PR #391] Move public headers to the "include" directory and expose them. #1001

New Issue

claunia · 2026-01-29T20:52:02Z

claunia commented

2026-01-29 20:52:02 +00:00

Original Pull Request: https://github.com/google/brotli/pull/391

State: closed
Merged: No

Public headers are now available via:

    #include <brotli/decode.h>
    #include <brotli/encode.h>
    #include <brotli/types.h>

    #include <brotli/compressor.h>
    #include <brotli/streams.h>

The exposure of "types.h" (which is only useful for MSVC builds) is
a bit unfortunate, but this change would be much bigger without it.

Makefile tested with "make test", BUILD file tested with ngx_brotli,
setup.py tested with "python setup.py build_ext test", premake5.lua
is broken, but it was broken before this change.

**Original Pull Request:** https://github.com/google/brotli/pull/391 **State:** closed **Merged:** No --- Public headers are now available via: ``` #include <brotli/decode.h> #include <brotli/encode.h> #include <brotli/types.h> #include <brotli/compressor.h> #include <brotli/streams.h> ``` The exposure of "types.h" (which is only useful for MSVC builds) is a bit unfortunate, but this change would be much bigger without it. Makefile tested with "make test", BUILD file tested with ngx_brotli, setup.py tested with "python setup.py build_ext test", premake5.lua is broken, but it was broken before this change.

claunia added the pull-request label 2026-01-29 20:52:02 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1001