[PR #407] [MERGED] Fix python build #1016

New Issue

claunia · 2026-01-29T20:52:06Z

claunia commented

2026-01-29 20:52:06 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/407
Author: @anthrotype
Created: 8/10/2016
Status: ✅ Merged
Merged: 8/11/2016
Merged by: @eustas

Base: master ← Head: fix-python-build

📝 Commits (7)

a5bf2c0 .travis.sh: activate virtualenv before calling python or pip commands
e944f1c .travis.yml: update Python versions
2dc2ac7 .travis.sh: explicitly use 'bash' shell instead of generic 'sh'
18dfca9 .travis.sh: only build wheels on OSX
13b8e7f .travis.yml: only deploy OSX wheels
52cb947 .travis.sh: skip source venv on linux
11dc16b .travis.yml: fix wheel deploy 'condition' (use '&&', not '||')

📊 Changes

2 files changed (+16 additions, -16 deletions)

View changed files

📝 .travis.sh (+11 -3)
📝 .travis.yml (+5 -13)

📄 Description

We need to source the virtual environment at the script and after_success stages inside.travis.sh script.

We can build and deploy only OSX wheels for now, but I will work on adding manylinux1 support later.

There's no need to build wheels using homebrew python (64bit only), as the wheels produced by Mac Python (from Python.org) are "universal", so they will work on homebrew python as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/407 **Author:** [@anthrotype](https://github.com/anthrotype) **Created:** 8/10/2016 **Status:** ✅ Merged **Merged:** 8/11/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `fix-python-build` --- ### 📝 Commits (7) - [`a5bf2c0`](https://github.com/google/brotli/commit/a5bf2c0bddca00d22c63ff2992539262997ff247) .travis.sh: activate virtualenv before calling python or pip commands - [`e944f1c`](https://github.com/google/brotli/commit/e944f1c92bcf9273b9708db28397bdf31a44a35c) .travis.yml: update Python versions - [`2dc2ac7`](https://github.com/google/brotli/commit/2dc2ac77016e845a6c6f143c6e975604e55301c9) .travis.sh: explicitly use 'bash' shell instead of generic 'sh' - [`18dfca9`](https://github.com/google/brotli/commit/18dfca9bc137c1aa24a85c65757b703198bef716) .travis.sh: only build wheels on OSX - [`13b8e7f`](https://github.com/google/brotli/commit/13b8e7ff605319428c603bb5e32b4f88318a1b73) .travis.yml: only deploy OSX wheels - [`52cb947`](https://github.com/google/brotli/commit/52cb947469e68905db28ca24949f8b309c62486d) .travis.sh: skip source venv on linux - [`11dc16b`](https://github.com/google/brotli/commit/11dc16bf918729778f4f38713315f4cd21e9e0ea) .travis.yml: fix wheel deploy 'condition' (use '&&', not '||') ### 📊 Changes **2 files changed** (+16 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.travis.sh` (+11 -3) 📝 `.travis.yml` (+5 -13) </details> ### 📄 Description We need to source the virtual environment at the `script` and `after_success` stages inside`.travis.sh` script. We can build and deploy only OSX wheels for now, but I will work on adding `manylinux1` support later. There's no need to build wheels using homebrew python (64bit only), as the wheels produced by Mac Python (from Python.org) are "universal", so they will work on homebrew python as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:06 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1016