[PR #418] [MERGED] Bazel: use cc_library instead of cc_inc_library. #1024

New Issue

claunia · 2026-01-29T20:52:09Z

claunia commented

2026-01-29 20:52:09 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/418
Author: @PiotrSikora
Created: 8/24/2016
Status: ✅ Merged
Merged: 8/24/2016
Merged by: @eustas

Base: master ← Head: bazel_cc_library

📝 Commits (1)

2cc3323 Bazel: use cc_library instead of cc_inc_library.

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 BUILD (+4 -3)

📄 Description

cc_inc_library is broken when used with external repositories
(see: https://github.com/bazelbuild/bazel/issues/1596), which
makes it a bit useless at the moment.

Switch to using cc_library with "includes" attribute to expose
public headers.

While there, fix order of attributes in ":brotli_common" target.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/418 **Author:** [@PiotrSikora](https://github.com/PiotrSikora) **Created:** 8/24/2016 **Status:** ✅ Merged **Merged:** 8/24/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `bazel_cc_library` --- ### 📝 Commits (1) - [`2cc3323`](https://github.com/google/brotli/commit/2cc33230f4583d788fee28979204c39f940eec14) Bazel: use cc_library instead of cc_inc_library. ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `BUILD` (+4 -3) </details> ### 📄 Description cc_inc_library is broken when used with external repositories (see: https://github.com/bazelbuild/bazel/issues/1596), which makes it a bit useless at the moment. Switch to using cc_library with "includes" attribute to expose public headers. While there, fix order of attributes in ":brotli_common" target. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:09 +00:00

claunia referenced this issue

2026-01-29 20:54:46 +00:00

[PR #1024] [MERGED] Fix Bazel build #1571

claunia referenced this issue

2026-01-29 20:54:46 +00:00

[PR #1024] Fix Bazel build #1576

Sign in to join this conversation.