[PR #418] Bazel: use cc_library instead of cc_inc_library. #1029

New Issue

claunia · 2026-01-29T20:52:10Z

claunia commented

2026-01-29 20:52:10 +00:00

Original Pull Request: https://github.com/google/brotli/pull/418

State: closed
Merged: Yes

cc_inc_library is broken when used with external repositories
(see: https://github.com/bazelbuild/bazel/issues/1596), which
makes it a bit useless at the moment.

Switch to using cc_library with "includes" attribute to expose
public headers.

While there, fix order of attributes in ":brotli_common" target.

**Original Pull Request:** https://github.com/google/brotli/pull/418 **State:** closed **Merged:** Yes --- cc_inc_library is broken when used with external repositories (see: https://github.com/bazelbuild/bazel/issues/1596), which makes it a bit useless at the moment. Switch to using cc_library with "includes" attribute to expose public headers. While there, fix order of attributes in ":brotli_common" target.

claunia added the pull-request label 2026-01-29 20:52:11 +00:00

claunia closed this issue

2026-01-29 20:52:11 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1029