[PR #434] [MERGED] Update research #1050

New Issue

claunia · 2026-01-29T20:52:17Z

claunia commented

2026-01-29 20:52:17 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/434
Author: @eustas
Created: 9/22/2016
Status: ✅ Merged
Merged: 9/22/2016
Merged by: @eustas

Base: master ← Head: master

📝 Commits (1)

dd8fa3e Update research

📊 Changes

7 files changed (+60 additions, -54 deletions)

View changed files

📝 Makefile (+5 -4)
📝 research/Makefile (+1 -1)
📝 research/draw_diff.cc (+8 -3)
📝 research/draw_histogram.cc (+19 -19)
📝 research/find_opt_references.cc (+7 -3)
📝 research/read_dist.h (+20 -10)
➖ tools/version.h (+0 -14)

📄 Description

don't use assert when side-effect is desired
use gflags to pick options from args

Other changes:

teach stub Makefile to do partial rebuild
remove obsolete tools/version.h

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/434 **Author:** [@eustas](https://github.com/eustas) **Created:** 9/22/2016 **Status:** ✅ Merged **Merged:** 9/22/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`dd8fa3e`](https://github.com/google/brotli/commit/dd8fa3e8ddb970fd92550d6e833870a813e4b164) Update research ### 📊 Changes **7 files changed** (+60 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+5 -4) 📝 `research/Makefile` (+1 -1) 📝 `research/draw_diff.cc` (+8 -3) 📝 `research/draw_histogram.cc` (+19 -19) 📝 `research/find_opt_references.cc` (+7 -3) 📝 `research/read_dist.h` (+20 -10) ➖ `tools/version.h` (+0 -14) </details> ### 📄 Description - don't use `assert` when side-effect is desired - use `gflags` to pick options from args Other changes: - teach stub `Makefile` to do partial rebuild - remove obsolete `tools/version.h` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:17 +00:00

claunia closed this issue

2026-01-29 20:52:17 +00:00

claunia referenced this issue

2026-01-29 20:54:53 +00:00

[PR #1050] [CLOSED] mention used code style #1604

claunia referenced this issue

2026-01-29 20:54:55 +00:00

[PR #1050] mention used code style #1609

Sign in to join this conversation.