[PR #437] [MERGED] Also install the brotli headers when building the shared libraries. #326 #1052

New Issue

claunia · 2026-01-29T20:52:17Z

claunia commented

2026-01-29 20:52:17 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/437
Author: @fred-wang
Created: 10/7/2016
Status: ✅ Merged
Merged: 10/12/2016
Merged by: @eustas

Base: master ← Head: cmake-include

📝 Commits (6)

89a77a9 Also install the brotli headers when building the shared libraries. #326
9393340 Actually use BROTLI_INCLUDE_DIRS to get the path to headers.
cd8153a Do not install the public headers on WIN32. #326
82536d2 Also install the libraries and headers when building static libraries.
c41962f Use install directories provided by GNUInstallDirs.
9389876 Add ARCHIVE destination for Windows.

📊 Changes

1 file changed (+9 additions, -6 deletions)

View changed files

📝 CMakeLists.txt (+9 -6)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/437 **Author:** [@fred-wang](https://github.com/fred-wang) **Created:** 10/7/2016 **Status:** ✅ Merged **Merged:** 10/12/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `cmake-include` --- ### 📝 Commits (6) - [`89a77a9`](https://github.com/google/brotli/commit/89a77a94bbc3faf7a93733f42e07f51d06605deb) Also install the brotli headers when building the shared libraries. #326 - [`9393340`](https://github.com/google/brotli/commit/93933405d35fdc8efbad4c7331b37505f947d430) Actually use BROTLI_INCLUDE_DIRS to get the path to headers. - [`cd8153a`](https://github.com/google/brotli/commit/cd8153a1ed221565584a9d181c2896228beb3c7e) Do not install the public headers on WIN32. #326 - [`82536d2`](https://github.com/google/brotli/commit/82536d2bae85084c8707bb16f6e81236d6fbb5e5) Also install the libraries and headers when building static libraries. - [`c41962f`](https://github.com/google/brotli/commit/c41962f0ae5bccb3ac4ddc86cfa2a0ef4bdd684c) Use install directories provided by GNUInstallDirs. - [`9389876`](https://github.com/google/brotli/commit/9389876ee9f47ec6ff9046296cae04103ee2d913) Add ARCHIVE destination for Windows. ### 📊 Changes **1 file changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+9 -6) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:17 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1052