[PR #450] [MERGED] Build shared libraries by default #1071

New Issue

claunia · 2026-01-29T20:52:22Z

claunia commented

2026-01-29 20:52:22 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/450
Author: @eustas
Created: 10/18/2016
Status: ✅ Merged
Merged: 10/18/2016
Merged by: @eustas

Base: master ← Head: master

📝 Commits (3)

69982c2 Build shared libraries by default
f5ba0b6 (compress_fragment_two_pass)
b93cb69 * leave static compilation declaration intouch (e.g. Python build)

📊 Changes

16 files changed (+123 additions, -88 deletions)

View changed files

📝 CMakeLists.txt (+7 -1)
📝 README.md (+2 -2)
📝 common/dictionary.h (+4 -3)
📝 dec/decode.c (+16 -16)
📝 enc/backward_references.c (+1 -1)
📝 enc/brotli_bit_stream.c (+1 -1)
📝 enc/compress_fragment.c (+8 -8)
📝 enc/compress_fragment_two_pass.c (+6 -6)
📝 enc/find_match_length.h (+3 -3)
📝 enc/hash.h (+1 -1)
📝 enc/hash_longest_match_inc.h (+2 -2)
📝 enc/hash_longest_match_quickly_inc.h (+2 -2)
📝 enc/ringbuffer.h (+2 -2)
📝 include/brotli/decode.h (+13 -10)
📝 include/brotli/encode.h (+17 -16)
📝 include/brotli/port.h (+38 -14)

📄 Description

Declare BUILD_SHARED_LIBS option for CMake
Define ${LIB}_SHARED_COMPILATION when compiling shared library
Define and use BROTLI_xxx_API
Fix remaining unprefixed defines in port.h

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/450 **Author:** [@eustas](https://github.com/eustas) **Created:** 10/18/2016 **Status:** ✅ Merged **Merged:** 10/18/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`69982c2`](https://github.com/google/brotli/commit/69982c25f155e6b5c72782f2c5590ead1b06aa61) Build shared libraries by default - [`f5ba0b6`](https://github.com/google/brotli/commit/f5ba0b6c17d73968eb3b2199b9041fd909a0eb29) (compress_fragment_two_pass) - [`b93cb69`](https://github.com/google/brotli/commit/b93cb69831093864a4312094c5b27d153f322a80) * leave static compilation declaration intouch (e.g. Python build) ### 📊 Changes **16 files changed** (+123 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+7 -1) 📝 `README.md` (+2 -2) 📝 `common/dictionary.h` (+4 -3) 📝 `dec/decode.c` (+16 -16) 📝 `enc/backward_references.c` (+1 -1) 📝 `enc/brotli_bit_stream.c` (+1 -1) 📝 `enc/compress_fragment.c` (+8 -8) 📝 `enc/compress_fragment_two_pass.c` (+6 -6) 📝 `enc/find_match_length.h` (+3 -3) 📝 `enc/hash.h` (+1 -1) 📝 `enc/hash_longest_match_inc.h` (+2 -2) 📝 `enc/hash_longest_match_quickly_inc.h` (+2 -2) 📝 `enc/ringbuffer.h` (+2 -2) 📝 `include/brotli/decode.h` (+13 -10) 📝 `include/brotli/encode.h` (+17 -16) 📝 `include/brotli/port.h` (+38 -14) </details> ### 📄 Description - Declare `BUILD_SHARED_LIBS` option for CMake - Define `${LIB}_SHARED_COMPILATION` when compiling shared library - Define and use `BROTLI_xxx_API` - Fix remaining unprefixed defines in port.h --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:22 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1071