[PR #465] [MERGED] bro: check return values of chown and chmod #1093

New Issue

claunia · 2026-01-29T20:52:28Z

claunia commented

2026-01-29 20:52:28 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/465
Author: @nemequ
Created: 11/2/2016
Status: ✅ Merged
Merged: 11/2/2016
Merged by: @eustas

Base: master ← Head: master

📝 Commits (1)

b139565 bro: check return values of chown and chmod

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 tools/bro.c (+12 -5)

📄 Description

Apparently some libc versions declare chown with the warn_unused_result attribute, which is enabled by default.

See https://travis-ci.org/quixdb/squash/jobs/172349806 . I don't see the problem with glibc-2.23 (on Fedora 24), but I guess the old version of glibc from Ubuntu 14.04 (where that is run) had it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/465 **Author:** [@nemequ](https://github.com/nemequ) **Created:** 11/2/2016 **Status:** ✅ Merged **Merged:** 11/2/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b139565`](https://github.com/google/brotli/commit/b139565d18e9fe6da26cd8c9aa2730b4109ef325) bro: check return values of chown and chmod ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `tools/bro.c` (+12 -5) </details> ### 📄 Description Apparently some libc versions declare chown with the warn_unused_result attribute, which is enabled by default. See https://travis-ci.org/quixdb/squash/jobs/172349806 . I don't see the problem with glibc-2.23 (on Fedora 24), but I guess the old version of glibc from Ubuntu 14.04 (where that is run) had it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:28 +00:00

claunia referenced this issue

2026-01-29 20:55:05 +00:00

[PR #1093] [CLOSED] fix wording #1639

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1093