[PR #478] [MERGED] Python: Convert bro.py tests to unittest style #1109

New Issue

claunia · 2026-01-29T20:52:33Z

claunia commented

2026-01-29 20:52:33 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/478
Author: @nicksay
Created: 12/9/2016
Status: ✅ Merged
Merged: 12/9/2016
Merged by: @eustas

Base: master ← Head: py-unittest-bro

📝 Commits (1)

cd07da7 Python: Convert bro.py tests to unittest style

📊 Changes

6 files changed (+159 additions, -213 deletions)

View changed files

📝 python/tests/_test_utils.py (+24 -17)
➕ python/tests/bro_test.py (+120 -0)
➖ python/tests/compatibility_test.py (+0 -30)
📝 python/tests/compress_test.py (+15 -77)
➖ python/tests/custom_dictionary_test.py (+0 -41)
➖ python/tests/roundtrip_test.py (+0 -48)

📄 Description

Create unittest-style tests for bro.py decompression and compression
Delete old tests for bro.py
Update test method generation to properly create a Cartesian product
of iterables using itertools.product

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/478 **Author:** [@nicksay](https://github.com/nicksay) **Created:** 12/9/2016 **Status:** ✅ Merged **Merged:** 12/9/2016 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `py-unittest-bro` --- ### 📝 Commits (1) - [`cd07da7`](https://github.com/google/brotli/commit/cd07da70446464e55327751a737c7dad2b24c3f8) Python: Convert bro.py tests to unittest style ### 📊 Changes **6 files changed** (+159 additions, -213 deletions) <details> <summary>View changed files</summary> 📝 `python/tests/_test_utils.py` (+24 -17) ➕ `python/tests/bro_test.py` (+120 -0) ➖ `python/tests/compatibility_test.py` (+0 -30) 📝 `python/tests/compress_test.py` (+15 -77) ➖ `python/tests/custom_dictionary_test.py` (+0 -41) ➖ `python/tests/roundtrip_test.py` (+0 -48) </details> ### 📄 Description * Create unittest-style tests for `bro.py` decompression and compression * Delete old tests for `bro.py` * Update test method generation to properly create a Cartesian product of iterables using `itertools.product` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:33 +00:00

claunia referenced this issue

2026-01-29 20:55:12 +00:00

[PR #1109] [MERGED] fix build for Microsoft-designed ARM64 ABI #1658

claunia referenced this issue

2026-01-29 20:55:13 +00:00

[PR #1109] fix build for Microsoft-designed ARM64 ABI #1662

Sign in to join this conversation.