mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
Compiler warnings about the visibility attribute from mingw #111
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nemequ on GitHub (May 25, 2016).
When attempting to cross-compile with mingw, I see a lot of "error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]" messages (normally they're just warnings, but I use -Werror for CI builds). See https://travis-ci.org/quixdb/squash/jobs/132697469#L1320 for an example. I can reproduce on Fedora with Squash with something like
ming64-cmake . && make -j.If you want, you can adapt
26aa037b61/squash/squash.h (L115)@eustas commented on GitHub (Jun 2, 2016):
Thanks. We're going to adapt it in few steps: first resolve the compiler warnings and later, when we are ready for windows, grab __declspec part.
@eustas commented on GitHub (Jun 9, 2016):
Should be fixed.
@nemequ commented on GitHub (Jun 9, 2016):
Looks like it's still an issue: https://travis-ci.org/quixdb/squash/jobs/136512277
That's with
09543b5fc5(you can verify that at https://travis-ci.org/quixdb/squash/jobs/136512277#L198).On a somewhat related note (an easy way to switch compilers), if you are interested I'd be willing to put together a CMake-based build system for you; it could be useful for Squash, too, since we could share the build system…
@eustas commented on GitHub (Jun 9, 2016):
Ooops, thought it was about unused function...
Visibility is fixed in v0.4, going to back-port fix soon.
@eustas commented on GitHub (Jun 10, 2016):
Should be fixed. Déjà vu?
@nemequ commented on GitHub (Jun 12, 2016):
Thanks, it works :)
https://travis-ci.org/quixdb/squash/builds/137077283