Compiler warnings about the visibility attribute from mingw #111

Closed
opened 2026-01-29 20:35:20 +00:00 by claunia · 6 comments
Owner

Originally created by @nemequ on GitHub (May 25, 2016).

When attempting to cross-compile with mingw, I see a lot of "error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]" messages (normally they're just warnings, but I use -Werror for CI builds). See https://travis-ci.org/quixdb/squash/jobs/132697469#L1320 for an example. I can reproduce on Fedora with Squash with something like ming64-cmake . && make -j.

If you want, you can adapt 26aa037b61/squash/squash.h (L115)

Originally created by @nemequ on GitHub (May 25, 2016). When attempting to cross-compile with mingw, I see a lot of "error: visibility attribute not supported in this configuration; ignored [-Werror=attributes]" messages (normally they're just warnings, but I use -Werror for CI builds). See https://travis-ci.org/quixdb/squash/jobs/132697469#L1320 for an example. I can reproduce on Fedora with Squash with something like `ming64-cmake . && make -j`. If you want, you can adapt https://github.com/quixdb/squash/blob/26aa037b618c1a37d984099b8dd5a3e04d3058c3/squash/squash.h#L115
Author
Owner

@eustas commented on GitHub (Jun 2, 2016):

Thanks. We're going to adapt it in few steps: first resolve the compiler warnings and later, when we are ready for windows, grab __declspec part.

@eustas commented on GitHub (Jun 2, 2016): Thanks. We're going to adapt it in few steps: first resolve the compiler warnings and later, when we are ready for windows, grab __declspec part.
Author
Owner

@eustas commented on GitHub (Jun 9, 2016):

Should be fixed.

@eustas commented on GitHub (Jun 9, 2016): Should be fixed.
Author
Owner

@nemequ commented on GitHub (Jun 9, 2016):

Looks like it's still an issue: https://travis-ci.org/quixdb/squash/jobs/136512277

That's with 09543b5fc5 (you can verify that at https://travis-ci.org/quixdb/squash/jobs/136512277#L198).

On a somewhat related note (an easy way to switch compilers), if you are interested I'd be willing to put together a CMake-based build system for you; it could be useful for Squash, too, since we could share the build system…

@nemequ commented on GitHub (Jun 9, 2016): Looks like it's still an issue: https://travis-ci.org/quixdb/squash/jobs/136512277 That's with 09543b5fc5637f1cda7a54dbf2b17f892006891b (you can verify that at https://travis-ci.org/quixdb/squash/jobs/136512277#L198). On a somewhat related note (an easy way to switch compilers), if you are interested I'd be willing to put together a CMake-based build system for you; it could be useful for Squash, too, since we could share the build system…
Author
Owner

@eustas commented on GitHub (Jun 9, 2016):

Ooops, thought it was about unused function...
Visibility is fixed in v0.4, going to back-port fix soon.

@eustas commented on GitHub (Jun 9, 2016): Ooops, thought it was about unused function... Visibility is fixed in v0.4, going to back-port fix soon.
Author
Owner

@eustas commented on GitHub (Jun 10, 2016):

Should be fixed. Déjà vu?

@eustas commented on GitHub (Jun 10, 2016): Should be fixed. _Déjà vu?_
Author
Owner

@nemequ commented on GitHub (Jun 12, 2016):

Thanks, it works :)

https://travis-ci.org/quixdb/squash/builds/137077283

@nemequ commented on GitHub (Jun 12, 2016): Thanks, it works :) https://travis-ci.org/quixdb/squash/builds/137077283
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#111