[PR #503] [CLOSED] Update encoder #1141

New Issue

claunia · 2026-01-29T20:52:39Z

claunia commented

2026-01-29 20:52:39 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/503
Author: @eustas
Created: 2/6/2017
Status: ❌ Closed

Base: master ← Head: oom

📝 Commits (2)

345450e Update encoder
ffee71e Fix build files

📊 Changes

25 files changed (+2483 additions, -2307 deletions)

View changed files

📝 CMakeLists.txt (+2 -0)
📝 common/constants.h (+1 -0)
📝 enc/backward_references.c (+7 -783)
📝 enc/backward_references.h (+1 -63)
➕ enc/backward_references_hq.c (+780 -0)
➕ enc/backward_references_hq.h (+98 -0)
📝 enc/backward_references_inc.h (+2 -7)
📝 enc/compress_fragment.c (+1 -2)
📝 enc/compress_fragment.h (+1 -1)
📝 enc/compress_fragment_two_pass.c (+1 -2)
📝 enc/compress_fragment_two_pass.h (+1 -1)
➕ enc/dictionary_hash.c (+1120 -0)
📝 enc/dictionary_hash.h (+1 -1101)
📝 enc/encode.c (+45 -20)
📝 enc/fast_log.h (+1 -1)
📝 enc/hash.h (+49 -319)
📝 enc/hash_forgetful_chain_inc.h (+9 -0)
📝 enc/hash_longest_match_inc.h (+9 -0)
📝 enc/hash_longest_match_quickly_inc.h (+14 -4)
➕ enc/hash_to_binary_tree_inc.h (+323 -0)

...and 5 more files

📄 Description

pull BROTLI_MAX_BACKWARD_LIMIT to constants
split generic and Zopfli backward references code
pull hashers init and stitch invocation to encoder
make dictionary_hash a compilation unit
add size hint parameter
add new hasher
use size hint to pick new hasher for q4
modernize clz guard (fix #495)
move hash to binary tree to separate file
add Initialize and Cleanup to all hashers
do not raise OOM if malloc(0) == NULL (fix #500)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/503 **Author:** [@eustas](https://github.com/eustas) **Created:** 2/6/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `oom` --- ### 📝 Commits (2) - [`345450e`](https://github.com/google/brotli/commit/345450ecef5de130fb5c593ea7a385b081f678d9) Update encoder - [`ffee71e`](https://github.com/google/brotli/commit/ffee71e026c2166a983d46fed6e3b823d762c5da) Fix build files ### 📊 Changes **25 files changed** (+2483 additions, -2307 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -0) 📝 `common/constants.h` (+1 -0) 📝 `enc/backward_references.c` (+7 -783) 📝 `enc/backward_references.h` (+1 -63) ➕ `enc/backward_references_hq.c` (+780 -0) ➕ `enc/backward_references_hq.h` (+98 -0) 📝 `enc/backward_references_inc.h` (+2 -7) 📝 `enc/compress_fragment.c` (+1 -2) 📝 `enc/compress_fragment.h` (+1 -1) 📝 `enc/compress_fragment_two_pass.c` (+1 -2) 📝 `enc/compress_fragment_two_pass.h` (+1 -1) ➕ `enc/dictionary_hash.c` (+1120 -0) 📝 `enc/dictionary_hash.h` (+1 -1101) 📝 `enc/encode.c` (+45 -20) 📝 `enc/fast_log.h` (+1 -1) 📝 `enc/hash.h` (+49 -319) 📝 `enc/hash_forgetful_chain_inc.h` (+9 -0) 📝 `enc/hash_longest_match_inc.h` (+9 -0) 📝 `enc/hash_longest_match_quickly_inc.h` (+14 -4) ➕ `enc/hash_to_binary_tree_inc.h` (+323 -0) _...and 5 more files_ </details> ### 📄 Description * pull `BROTLI_MAX_BACKWARD_LIMIT` to constants * split generic and Zopfli backward references code * pull hashers init and stitch invocation to encoder * make `dictionary_hash` a compilation unit * add `size hint` parameter * add new hasher * use `size hint` to pick new hasher for q4 * modernize clz guard (fix #495) * move `hash to binary tree` to separate file * add `Initialize` and `Cleanup` to all hashers * do not raise OOM if `malloc(0) == NULL` (fix #500) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:52:39 +00:00

claunia closed this issue

2026-01-29 20:52:39 +00:00

claunia referenced this issue

2026-01-29 20:55:25 +00:00

[PR #1141] Inline `hash_mul_`. #1704

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1141