[PR #599] [MERGED] Build both static and shared libs with CMake #1244

New Issue

claunia · 2026-01-29T20:53:09Z

claunia commented

2026-01-29 20:53:09 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/599
Author: @eustas
Created: 9/18/2017
Status: ✅ Merged
Merged: 9/19/2017
Merged by: @eustas

Base: master ← Head: cmake-both

📝 Commits (9)

cb6f7df Build both static and shared libs with CMake
4e5cb35 Don't add "shared" define on static libraries.
9a63f76 Fix define name
908707f Fix regex-replace params.
b88e083 Define "BROTLI_SHARED" only for shared libraries
67ba056 Combing
afb2dd0 replace "add_definitions" with target properties
1f6ed0f Use "target compile definitions"
16f1160 Make "BROTLI_SHARED_COMPILATION" public.

📊 Changes

2 files changed (+34 additions, -23 deletions)

View changed files

📝 CMakeLists.txt (+34 -20)
📝 scripts/.configure-custom.sh (+0 -3)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/599 **Author:** [@eustas](https://github.com/eustas) **Created:** 9/18/2017 **Status:** ✅ Merged **Merged:** 9/19/2017 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `cmake-both` --- ### 📝 Commits (9) - [`cb6f7df`](https://github.com/google/brotli/commit/cb6f7dff3c7f8c6ab14dfc58bbbc9bf31d285938) Build both static and shared libs with CMake - [`4e5cb35`](https://github.com/google/brotli/commit/4e5cb352506500ad8c1f271b8856ad2ae0ffbff6) Don't add "shared" define on static libraries. - [`9a63f76`](https://github.com/google/brotli/commit/9a63f7663d5b09f2311139963e6348ef08de7e11) Fix define name - [`908707f`](https://github.com/google/brotli/commit/908707f2796e0bb5936517e4ea8f7b16d6829136) Fix regex-replace params. - [`b88e083`](https://github.com/google/brotli/commit/b88e08325b7c11c149942b779a988ff2672d5285) Define "BROTLI_SHARED" only for shared libraries - [`67ba056`](https://github.com/google/brotli/commit/67ba0561bf96c316382b6eba20d5cad81ef70792) Combing - [`afb2dd0`](https://github.com/google/brotli/commit/afb2dd009b0163630a0281616b9e387f91545dca) replace "add_definitions" with target properties - [`1f6ed0f`](https://github.com/google/brotli/commit/1f6ed0fdebcc68c36a50a7c43598fb27037a6fba) Use "target compile definitions" - [`16f1160`](https://github.com/google/brotli/commit/16f1160d177dbbf293447119f318359e354c1165) Make "BROTLI_SHARED_COMPILATION" public. ### 📊 Changes **2 files changed** (+34 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+34 -20) 📝 `scripts/.configure-custom.sh` (+0 -3) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:09 +00:00

claunia referenced this issue

2026-01-29 20:55:54 +00:00

[PR #1244] [MERGED] Add release notes for recent python API update #1809

claunia referenced this issue

2026-01-29 20:55:55 +00:00

[PR #1244] Add release notes for recent python API update #1814

Sign in to join this conversation.