[PR #623] [MERGED] Fix missing symbols errors in libbrotlienc and dec #1268

Open
opened 2026-01-29 20:53:15 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/623
Author: @Sp1l
Created: 11/29/2017
Status: Merged
Merged: 11/29/2017
Merged by: @eustas

Base: masterHead: patch-1


📝 Commits (1)

  • 261e8f1 Fix missing symbols errors in libbrotlienc and dec

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 Makefile.am (+2 -0)

📄 Description

When using autotools to build the binary and libraries, the resulting libraries don't link brotlicommon or m.
This was detected when building cURL 7.57.0 which has now has brotli support. During configure it was failing

checking run-time libs availability... failed
configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lbrotlidec -lz -L/usr/local/lib

inspection of config.log showed missing symbols from libbrotlicommon as the cause.

This patch results in the encryption and decryption libs to be properly linked against libbrotlicommon and libm.
See also https://bugs.freebsd.org/223966


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/623 **Author:** [@Sp1l](https://github.com/Sp1l) **Created:** 11/29/2017 **Status:** ✅ Merged **Merged:** 11/29/2017 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`261e8f1`](https://github.com/google/brotli/commit/261e8f12f43371fe7639aca9c609a20cad8d91bb) Fix missing symbols errors in libbrotlienc and dec ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.am` (+2 -0) </details> ### 📄 Description When using autotools to build the binary and libraries, the resulting libraries don't link `brotlicommon` or `m`. This was detected when building cURL 7.57.0 which has now has brotli support. During configure it was failing ``` checking run-time libs availability... failed configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lbrotlidec -lz -L/usr/local/lib ``` inspection of config.log showed missing symbols from libbrotlicommon as the cause. This patch results in the encryption and decryption libs to be properly linked against libbrotlicommon and libm. See also https://bugs.freebsd.org/223966 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 20:53:15 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#1268