[PR #627] [MERGED] Work around Linuxisms #1273

New Issue

claunia · 2026-01-29T20:53:18Z

claunia commented

2026-01-29 20:53:18 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/627
Author: @Sp1l
Created: 12/4/2017
Status: ✅ Merged
Merged: 12/4/2017
Merged by: @eustas

Base: master ← Head: patch-2

📝 Commits (1)

b878174 Work around Linuxisms

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 bootstrap (+4 -2)

📄 Description

Missed this in my previous tests. Sorry for that.

On BSDs, both bc and sed are part of the base operating system. For sed this results in an error as the check construct (--version) is a GNU-ism and only works for GNU sed, not for bsd sed.
Similarly, BSD sed does not take parameters after the filename(s) operated on. Moving -i to the front fixes that. -r is provided for GNU compat in BSD sed as an alias of -E. The -i option in BSD sed requires an extension to work in-place.

(thank you for picking up the nginx module too!)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/627 **Author:** [@Sp1l](https://github.com/Sp1l) **Created:** 12/4/2017 **Status:** ✅ Merged **Merged:** 12/4/2017 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`b878174`](https://github.com/google/brotli/commit/b878174fd4c2e12479904d95612ea9dd9173db3b) Work around Linuxisms ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bootstrap` (+4 -2) </details> ### 📄 Description Missed this in my previous tests. Sorry for that. On BSDs, both bc and sed are part of the base operating system. For sed this results in an error as the check construct (--version) is a GNU-ism and only works for GNU sed, not for bsd sed. Similarly, BSD sed does not take parameters after the filename(s) operated on. Moving `-i` to the front fixes that. `-r` is provided for GNU compat in BSD sed as an alias of `-E`. The `-i` option in BSD sed requires an extension to work in-place. (thank you for picking up the nginx module too!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:18 +00:00

claunia referenced this issue

2026-01-29 20:56:07 +00:00

[PR #1273] [MERGED] Prepare for transpilation to golang #1846

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1273