[PR #645] [CLOSED] Fix soname version #1292

New Issue

claunia · 2026-01-29T20:53:22Z

claunia commented

2026-01-29 20:53:22 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/645
Author: @mcatanzaro
Created: 3/7/2018
Status: ❌ Closed

Base: master ← Head: soversion

📝 Commits (1)

0d63d7c Fix soname version

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)

📄 Description

0ad94eed00 changed the libbrotli libraries' soname
version from 1.0.1 (following standard conventions) to just 1. This isn't the end of the world,
but it seems like a mistake.

See also: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/O6W3HE445NYZRVVFGLA2OTAR7ZHRFHI2/

Note: this is 100% totally untested: I just skimmed though the git history looking for suspicious commits and decided to undo the suspicious thing. But I think it should be fine.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/645 **Author:** [@mcatanzaro](https://github.com/mcatanzaro) **Created:** 3/7/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `soversion` --- ### 📝 Commits (1) - [`0d63d7c`](https://github.com/google/brotli/commit/0d63d7c1d1b44d11903c9a61dff4050b5df6c7f3) Fix soname version ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) </details> ### 📄 Description 0ad94eed00420bf1154cb16a289aa27efbb30c01 changed the libbrotli libraries' soname version from 1.0.1 (following standard conventions) to just 1. This isn't the end of the world, but it seems like a mistake. See also: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/O6W3HE445NYZRVVFGLA2OTAR7ZHRFHI2/ Note: this is 100% totally untested: I just skimmed though the git history looking for suspicious commits and decided to undo the suspicious thing. But I think it should be fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:22 +00:00

claunia closed this issue

2026-01-29 20:53:22 +00:00

claunia referenced this issue

2026-01-29 20:56:15 +00:00

[PR #1292] [MERGED] Fixed typo #1874

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1292