Appveyor skips uploading artifacts for 0.5.0 (complains tag already exists) #131

New Issue

claunia · 2026-01-29T20:37:00Z

claunia commented

2026-01-29 20:37:00 +00:00

Originally created by @anthrotype on GitHub (Aug 11, 2016).

Deploying using GitHub provider
Creating "v0.5.0" release for repository "google/brotli" tag "v0.5.0" commit "2e0d3214c2b6248a486822d2c5267d1c961a29d0"...Skipped - release with tag "v0.5.0" already exists
No artifacts were published. Make sure you have specified correct artifacts filter.

https://ci.appveyor.com/project/szabadka/brotli/build/1.0.502/job/sstt93cb5onyte0w#L390

Originally created by @anthrotype on GitHub (Aug 11, 2016). ``` Deploying using GitHub provider Creating "v0.5.0" release for repository "google/brotli" tag "v0.5.0" commit "2e0d3214c2b6248a486822d2c5267d1c961a29d0"...Skipped - release with tag "v0.5.0" already exists No artifacts were published. Make sure you have specified correct artifacts filter. ``` https://ci.appveyor.com/project/szabadka/brotli/build/1.0.502/job/sstt93cb5onyte0w#L390

claunia closed this issue

2026-01-29 20:37:03 +00:00

claunia commented

2026-01-29 20:37:04 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

sorry, I jumped the gun. It is working fine.

@anthrotype commented on GitHub (Aug 11, 2016): sorry, I jumped the gun. It is working fine.

claunia commented

2026-01-29 20:37:06 +00:00

@eustas commented on GitHub (Aug 11, 2016):

Released as 0.5.1 to be safe

@eustas commented on GitHub (Aug 11, 2016): Released as 0.5.1 to be safe

claunia commented

2026-01-29 20:37:07 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

ops, I'm sorry I had you create the 0.5.1 tag... :(

@anthrotype commented on GitHub (Aug 11, 2016): ops, I'm sorry I had you create the 0.5.1 tag... :(

claunia commented

2026-01-29 20:37:09 +00:00

@eustas commented on GitHub (Aug 11, 2016):

No worries.

@eustas commented on GitHub (Aug 11, 2016): No worries.

claunia commented

2026-01-29 20:37:11 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

something might have gone wrong with the 0.5.0 tag. Some of the Windown 32-bit wheels are missing, as if subsequent builds on Appveyor have overwritten the existing Github release, deleting the files uploaded by the previous build.
So let's cross fingers with 0.5.1...

@anthrotype commented on GitHub (Aug 11, 2016): something might have gone wrong with the 0.5.0 tag. Some of the Windown 32-bit wheels are missing, as if subsequent builds on Appveyor have overwritten the existing Github release, deleting the files uploaded by the previous build. So let's cross fingers with 0.5.1...

claunia commented

2026-01-29 20:37:12 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

ouch. The upload to 0.5.1 is now working fine from Appveyor, but the version string in the setup.py is still 0.5.0, so the wheels are named like that...

The solution is deprecate 0.5.1, commit a version string change (0.5.2?), and cut a new tag.
Sorry you have to go through this mess.

@anthrotype commented on GitHub (Aug 11, 2016): ouch. The upload to 0.5.1 is now working fine from Appveyor, but the version string in the setup.py is still 0.5.0, so the wheels are named like that... The solution is deprecate 0.5.1, commit a version string change (0.5.2?), and cut a new tag. Sorry you have to go through this mess.

claunia commented

2026-01-29 20:37:15 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

the BROTLI_VERSION in tools/version.h should match the latest tag version.

There are tools like setuptools_scm, which take care of updating the package version (as well as the one in the header file) based on the latest git tag, when one generates a new source distribution, so that you won't need to remember to manually update the version file, but simply make an annotated tag.

But maybe that's overkill.

@anthrotype commented on GitHub (Aug 11, 2016): the `BROTLI_VERSION` in `tools/version.h` should match the latest tag version. There are tools like `setuptools_scm`, which take care of updating the package version (as well as the one in the header file) based on the latest git tag, when one generates a new source distribution, so that you won't need to remember to manually update the version file, but simply make an annotated tag. But maybe that's overkill.

claunia commented

2026-01-29 20:37:16 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

for the python packages to have the right version string (matching the latest tag) you need to modify the tools/version.h file like this:

https://github.com/google/brotli/blob/master/tools/version.h#L12

-#define BROTLI_VERSION "0.5.0"
+#define BROTLI_VERSION "0.5.2"

@anthrotype commented on GitHub (Aug 11, 2016): for the python packages to have the right version string (matching the latest tag) you need to modify the `tools/version.h` file like this: https://github.com/google/brotli/blob/master/tools/version.h#L12 ``` diff -#define BROTLI_VERSION "0.5.0" +#define BROTLI_VERSION "0.5.2" ```

claunia commented

2026-01-29 20:37:18 +00:00

@eustas commented on GitHub (Aug 11, 2016):

Ooops. Released from master instead of branch.

@eustas commented on GitHub (Aug 11, 2016): Ooops. Released from master instead of branch.

claunia commented

2026-01-29 20:37:20 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

still no luck. :(
the 3.4 and 3.5 mac wheels in 0.5.2 release are still using 0.5.0 version
https://github.com/google/brotli/releases/tag/v0.5.2

@anthrotype commented on GitHub (Aug 11, 2016): still no luck. :( the 3.4 and 3.5 mac wheels in 0.5.2 release are still using 0.5.0 version https://github.com/google/brotli/releases/tag/v0.5.2

claunia commented

2026-01-29 20:37:22 +00:00

@anthrotype commented on GitHub (Aug 11, 2016):

actually no! they are just duplicate. The ones with the correct 0.5.2 version are also there.
Can you please manually delete the 0.5.0 ones, to avoid any confusions?
Thank you very much.

@anthrotype commented on GitHub (Aug 11, 2016): actually no! they are just duplicate. The ones with the correct 0.5.2 version are also there. Can you please manually delete the 0.5.0 ones, to avoid any confusions? Thank you very much.

claunia commented

2026-01-29 20:37:24 +00:00

@eustas commented on GitHub (Aug 12, 2016):

Done =)

@eustas commented on GitHub (Aug 12, 2016): Done =)

claunia commented

2026-01-29 20:37:26 +00:00

@anthrotype commented on GitHub (Aug 12, 2016):

Thanks! Looks good now 👍

@anthrotype commented on GitHub (Aug 12, 2016): Thanks! Looks good now 👍

claunia referenced this issue

2026-01-29 20:50:39 +00:00