[PR #677] [MERGED] Inverse bazel project/workspace tree #1323

New Issue

claunia · 2026-01-29T20:53:31Z

claunia commented

2026-01-29 20:53:31 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/677
Author: @eustas
Created: 5/31/2018
Status: ✅ Merged
Merged: 6/4/2018
Merged by: @eustas

Base: master ← Head: inverse-bzl

📝 Commits (10+)

03c3470 Inverse bazel workspace tree.
f770ade Fix Appveyor / Travis Bazel invocations.
5696106 Fix build scripts
c1a950f Do not "test" research subproject.
7a822a9 Try to fix appveyor
9e60120 Update "linker" script
1c21ab6 Ditto
aa6b14c dr
7fa3669 take 3
efe4231 take4

📊 Changes

21 files changed (+319 additions, -294 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 BUILD (+0 -87)
📝 WORKSPACE (+12 -87)
📝 c/common/transform.h (+1 -1)
➕ go/BUILD (+3 -0)
➕ go/WORKSPACE (+16 -0)
📝 go/cbrotli/BUILD (+2 -2)
➕ java/BUILD (+86 -0)
➕ java/WORKSPACE (+69 -0)
📝 java/org/brotli/dec/DictionaryData.java (+1 -0)
📝 java/org/brotli/integration/BUILD (+10 -10)
📝 java/org/brotli/wrapper/common/BUILD (+17 -21)
📝 java/org/brotli/wrapper/common/SetRfcDictionaryTest.java (+8 -29)
📝 java/org/brotli/wrapper/dec/BUILD (+19 -22)
📝 java/org/brotli/wrapper/enc/BUILD (+20 -25)
➕ js/WORKSPACE (+14 -0)
📝 research/BUILD (+1 -1)
➕ research/WORKSPACE (+12 -0)
📝 scripts/.travis.sh (+5 -1)
📝 scripts/appveyor.yml (+14 -5)

...and 1 more files

📄 Description

Now each subproject directly depends on root (c) project.

This helps to mitigate Bazel bug bazelbuild/bazel#2391; short summary:
Bazel does not work if referenced subproject WORKSPACE uses any
repositories that embedding project does not.

Bright side: building C project is much faster;
no need to download closure, go and JDK...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/677 **Author:** [@eustas](https://github.com/eustas) **Created:** 5/31/2018 **Status:** ✅ Merged **Merged:** 6/4/2018 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `inverse-bzl` --- ### 📝 Commits (10+) - [`03c3470`](https://github.com/google/brotli/commit/03c34704c98ff62e230e26b5071fe46db97308eb) Inverse bazel workspace tree. - [`f770ade`](https://github.com/google/brotli/commit/f770adee95b215794ff297a57abf2b7b261d6f8b) Fix Appveyor / Travis Bazel invocations. - [`5696106`](https://github.com/google/brotli/commit/5696106cca105871e133317ef79d44f823e990d8) Fix build scripts - [`c1a950f`](https://github.com/google/brotli/commit/c1a950f8ec02afa54323065714c66c6b7c4cda69) Do not "test" research subproject. - [`7a822a9`](https://github.com/google/brotli/commit/7a822a9d124d5f122b8fcff93467cac2e782edf8) Try to fix appveyor - [`9e60120`](https://github.com/google/brotli/commit/9e601203e65641860b2d575e665b34d910ee505b) Update "linker" script - [`1c21ab6`](https://github.com/google/brotli/commit/1c21ab663fb9be4993d694e397577f6349ab976a) Ditto - [`aa6b14c`](https://github.com/google/brotli/commit/aa6b14c52cfe6a6aadb98448dbdb8710eedf9ba0) dr - [`7fa3669`](https://github.com/google/brotli/commit/7fa366911430773e51244317b6de873dc3c04fc6) take 3 - [`efe4231`](https://github.com/google/brotli/commit/efe423191ab1ed41bd9cd9e5a88a8aa9833e23b3) take4 ### 📊 Changes **21 files changed** (+319 additions, -294 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `BUILD` (+0 -87) 📝 `WORKSPACE` (+12 -87) 📝 `c/common/transform.h` (+1 -1) ➕ `go/BUILD` (+3 -0) ➕ `go/WORKSPACE` (+16 -0) 📝 `go/cbrotli/BUILD` (+2 -2) ➕ `java/BUILD` (+86 -0) ➕ `java/WORKSPACE` (+69 -0) 📝 `java/org/brotli/dec/DictionaryData.java` (+1 -0) 📝 `java/org/brotli/integration/BUILD` (+10 -10) 📝 `java/org/brotli/wrapper/common/BUILD` (+17 -21) 📝 `java/org/brotli/wrapper/common/SetRfcDictionaryTest.java` (+8 -29) 📝 `java/org/brotli/wrapper/dec/BUILD` (+19 -22) 📝 `java/org/brotli/wrapper/enc/BUILD` (+20 -25) ➕ `js/WORKSPACE` (+14 -0) 📝 `research/BUILD` (+1 -1) ➕ `research/WORKSPACE` (+12 -0) 📝 `scripts/.travis.sh` (+5 -1) 📝 `scripts/appveyor.yml` (+14 -5) _...and 1 more files_ </details> ### 📄 Description Now each subproject directly depends on root (c) project. This helps to mitigate Bazel bug bazelbuild/bazel#2391; short summary: Bazel does not work if referenced subproject `WORKSPACE` uses any repositories that embedding project does not. Bright side: building C project is much faster; no need to download closure, go and JDK... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:31 +00:00

claunia referenced this issue

2026-01-29 20:56:26 +00:00

[PR #1323] [MERGED] Bump actions/setup-python from 5.6.0 to 6.0.0 #1912

claunia referenced this issue

2026-01-29 20:56:26 +00:00

[PR #1323] Bump actions/setup-python from 5.6.0 to 6.0.0 #1914

Sign in to join this conversation.