[PR #703] [MERGED] decode: faster huffman code loading on 32-bit Arm #1345

New Issue

claunia · 2026-01-29T20:53:37Z

claunia commented

2026-01-29 20:53:37 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/703
Author: @stephenkyle-ARM
Created: 8/15/2018
Status: ✅ Merged
Merged: 9/27/2018
Merged by: @eustas

Base: master ← Head: perf/faster-symbol-load-arm

📝 Commits (3)

5997989 platform: add macro for using the 'aligned' attribute
887e864 decode: add accessor macros for HuffmanCode fields
f051af8 decode: add alternative accessors for HuffmanCode on Arm AArch32

📊 Changes

4 files changed (+139 additions, -84 deletions)

View changed files

📝 c/common/platform.h (+7 -1)
📝 c/dec/decode.c (+45 -36)
📝 c/dec/huffman.c (+32 -47)
📝 c/dec/huffman.h (+55 -0)

📄 Description

In both symbol preloading and decoding, force the compiler to generate a
single load instead of two when loading the bits and value fields of the
HuffmanCode struct.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/703 **Author:** [@stephenkyle-ARM](https://github.com/stephenkyle-ARM) **Created:** 8/15/2018 **Status:** ✅ Merged **Merged:** 9/27/2018 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `perf/faster-symbol-load-arm` --- ### 📝 Commits (3) - [`5997989`](https://github.com/google/brotli/commit/5997989f0621a8c2cbf9165f53363939ed33ffb9) platform: add macro for using the 'aligned' attribute - [`887e864`](https://github.com/google/brotli/commit/887e864ac9f2866730ae668758c1e49cefeeebfb) decode: add accessor macros for HuffmanCode fields - [`f051af8`](https://github.com/google/brotli/commit/f051af8ad0da865f167f0f417159cbbcd694ab69) decode: add alternative accessors for HuffmanCode on Arm AArch32 ### 📊 Changes **4 files changed** (+139 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `c/common/platform.h` (+7 -1) 📝 `c/dec/decode.c` (+45 -36) 📝 `c/dec/huffman.c` (+32 -47) 📝 `c/dec/huffman.h` (+55 -0) </details> ### 📄 Description In both symbol preloading and decoding, force the compiler to generate a single load instead of two when loading the bits and value fields of the HuffmanCode struct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:37 +00:00

claunia referenced this issue

2026-01-29 20:56:35 +00:00

[PR #1345] [MERGED] Fix some typos / non-typos. #1947

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1345