[PR #702] platform: fix unaligned 64-bit accesses on AArch32 #1347

New Issue

claunia · 2026-01-29T20:53:37Z

claunia commented

2026-01-29 20:53:37 +00:00

Original Pull Request: https://github.com/google/brotli/pull/702

State: closed
Merged: Yes

Ensures that Aarch32 Arm builds with an Armv8 compiler do not set
BROTLI_64_BITS.

This scenario is possible with ChromeOS builds, as they may use a
toolchain with the target armv7-cros-gnueabi, but with -march=armv8.
This will set __ARM_ARCH to 8 (defining BROTLI_TARGET_ARMV8), but will
also set __ARM_32BIT_STATE and not __ARM_64BIT_STATE. Without this,
illegal 64-bit non-word-aligned reads (LDRD) may be emitted.

Also fix unaligned 64-bit reads on AArch32 - STRD was still possible to
emit.

**Original Pull Request:** https://github.com/google/brotli/pull/702 **State:** closed **Merged:** Yes --- Ensures that Aarch32 Arm builds with an Armv8 compiler do not set BROTLI_64_BITS. This scenario is possible with ChromeOS builds, as they may use a toolchain with the target armv7-cros-gnueabi, but with -march=armv8. This will set __ARM_ARCH to 8 (defining BROTLI_TARGET_ARMV8), but will also set __ARM_32BIT_STATE and not __ARM_64BIT_STATE. Without this, illegal 64-bit non-word-aligned reads (LDRD) may be emitted. Also fix unaligned 64-bit reads on AArch32 - STRD was still possible to emit.

claunia added the pull-request label 2026-01-29 20:53:37 +00:00

claunia referenced this issue

2026-01-29 20:56:37 +00:00

[PR #1347] [MERGED] Bump ossf/scorecard-action from 2.4.2 to 2.4.3 #1950

claunia referenced this issue

2026-01-29 20:56:37 +00:00

[PR #1347] Bump ossf/scorecard-action from 2.4.2 to 2.4.3 #1953

Sign in to join this conversation.