[PR #704] [MERGED] Fix auto detect of bundled mode #1349

New Issue

claunia · 2026-01-29T20:53:39Z

claunia commented

2026-01-29 20:53:39 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/704
Author: @jibsen
Created: 8/28/2018
Status: ✅ Merged
Merged: 9/13/2018
Merged by: @eustas

Base: master ← Head: fix-cmake-bundled

📝 Commits (1)

803915f Fix auto detect of bundled mode

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 CMakeLists.txt (+3 -3)

📄 Description

Set bundled mode to ON when parent directory is not empty.

This likely never became an issue due to the (strange) way if works in CMake; if you compare an undefined variable to the empty string the result is false. So the code to set BROTLI_BUNDLED_MODE never ran, and the uses later in the file are as boolean values, where undefined is false.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/704 **Author:** [@jibsen](https://github.com/jibsen) **Created:** 8/28/2018 **Status:** ✅ Merged **Merged:** 9/13/2018 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `fix-cmake-bundled` --- ### 📝 Commits (1) - [`803915f`](https://github.com/google/brotli/commit/803915f352993c2b54e48183fe6cc5cb009e8e60) Fix auto detect of bundled mode ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+3 -3) </details> ### 📄 Description Set bundled mode to ON when parent directory is not empty. This likely never became an issue due to the (strange) way if works in CMake; if you compare an undefined variable to the empty string the result is false. So the code to set BROTLI_BUNDLED_MODE never ran, and the uses later in the file are as boolean values, where undefined is false. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:39 +00:00

claunia referenced this issue

2026-01-29 20:56:37 +00:00

[PR #1349] [MERGED] pick changes from Debian patch #1952

claunia referenced this issue

2026-01-29 20:56:37 +00:00

[PR #1349] pick changes from Debian patch #1956

Sign in to join this conversation.