[PR #704] Fix auto detect of bundled mode #1352

New Issue

claunia · 2026-01-29T20:53:39Z

claunia commented

2026-01-29 20:53:39 +00:00

Original Pull Request: https://github.com/google/brotli/pull/704

State: closed
Merged: Yes

Set bundled mode to ON when parent directory is not empty.

This likely never became an issue due to the (strange) way if works in CMake; if you compare an undefined variable to the empty string the result is false. So the code to set BROTLI_BUNDLED_MODE never ran, and the uses later in the file are as boolean values, where undefined is false.

**Original Pull Request:** https://github.com/google/brotli/pull/704 **State:** closed **Merged:** Yes --- Set bundled mode to ON when parent directory is not empty. This likely never became an issue due to the (strange) way if works in CMake; if you compare an undefined variable to the empty string the result is false. So the code to set BROTLI_BUNDLED_MODE never ran, and the uses later in the file are as boolean values, where undefined is false.

claunia added the pull-request label 2026-01-29 20:53:39 +00:00

claunia referenced this issue

2026-01-29 20:56:37 +00:00

[PR #1352] [CLOSED] Bump softprops/action-gh-release from 2.3.4 to 2.4.1 #1954

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1352