[PR #714] decode: fix NEON inclusion #1361

New Issue

claunia · 2026-01-29T20:53:42Z

claunia commented

2026-01-29 20:53:42 +00:00

Original Pull Request: https://github.com/google/brotli/pull/714

State: closed
Merged: Yes

The macro that checks for NEON support should be __ARM_NEON, not
ARM_NEON. [1]

AArch64 compilers define __ARM_NEON but not ARM_NEON.
AArch32 compilers currently seem to define both, but could be within their
rights to drop ARM_NEON in future versions.

This change moves the check into the common/platform.h file, checks for
both forms, and sets BROTLI_TARGET_NEON if NEON support is available.

[1] Section 6.5.4 of the ARM C Language Extensions.
(At the time of writing, the latest version was Release 2.1.)

**Original Pull Request:** https://github.com/google/brotli/pull/714 **State:** closed **Merged:** Yes --- The macro that checks for NEON support should be __ARM_NEON, not __ARM_NEON__. [1] AArch64 compilers define __ARM_NEON but not __ARM_NEON__. AArch32 compilers currently seem to define both, but could be within their rights to drop __ARM_NEON__ in future versions. This change moves the check into the common/platform.h file, checks for both forms, and sets BROTLI_TARGET_NEON if NEON support is available. [1] Section 6.5.4 of the ARM C Language Extensions. (At the time of writing, the latest version was Release 2.1.)

claunia added the pull-request label 2026-01-29 20:53:42 +00:00

claunia closed this issue

2026-01-29 20:53:42 +00:00

claunia referenced this issue

2026-01-29 20:56:41 +00:00

[PR #1361] [MERGED] regenerate go/kt/js/ts #1964

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1361