mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
Combine port.h files #139
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mdejong on GitHub (Aug 30, 2016).
Hello
I recently compiled brotli under Xcode for use in an iOS project and I hit one little snag. The files dec/port.h and common/port.h have the exact same filename and this makes it difficult to setup an Xcode project where all the brotli files live in one directory. Could you please rename common/port.h to common/common_port.h (or perhaps common/cport.h) so that it is possible to import these files into an Xcode project without a conflict. The built in include files logic in an Xcode project are a little weird and this change would make things a lot easier.
@eustas commented on GitHub (Aug 31, 2016):
Does this problem occur with CMake or Premake5 generated XCode projects?
@mdejong commented on GitHub (Aug 31, 2016):
No, I am building in Xcode but creating a new directory layout and the only catch is the fact that the same filename is being used in different directories. It is not a problem if you don't change anything and use the existing build structure, but then it is harder to integrate into an existing Xcode project as source code.
@eustas commented on GitHub (Sep 12, 2016):
Ideally, there will be only one port.h, and we are moving towards this.
Feel free to ping me, if this is urgent.
@eustas commented on GitHub (Dec 12, 2017):
Will be fixed in #630