[PR #780] [MERGED] Add missing "const" to a couple of kConstants #1404

New Issue

claunia · 2026-01-29T20:53:54Z

claunia commented

2026-01-29 20:53:54 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/780
Author: @agrieve
Created: 11/14/2019
Status: ✅ Merged
Merged: 12/19/2019
Merged by: @eustas

Base: master ← Head: mutable-constants

📝 Commits (1)

fb11f6d Add missing "const" to a couple of kConstants

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 c/common/dictionary.c (+10 -1)
📝 c/common/transform.c (+1 -1)

📄 Description

These showed up in a Chromium audit:
https://bugs.chromium.org/p/chromium/issues/detail?id=747064#c8

Although already effectively const, adding "const" causes the symbols to
be moved into the read-only section of the binary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/780 **Author:** [@agrieve](https://github.com/agrieve) **Created:** 11/14/2019 **Status:** ✅ Merged **Merged:** 12/19/2019 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `mutable-constants` --- ### 📝 Commits (1) - [`fb11f6d`](https://github.com/google/brotli/commit/fb11f6dca87c7cae73fd9ba9bdcefceb8bd2b21f) Add missing "const" to a couple of kConstants ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `c/common/dictionary.c` (+10 -1) 📝 `c/common/transform.c` (+1 -1) </details> ### 📄 Description These showed up in a Chromium audit: https://bugs.chromium.org/p/chromium/issues/detail?id=747064#c8 Although already effectively const, adding "const" causes the symbols to be moved into the read-only section of the binary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:54 +00:00

claunia referenced this issue

2026-01-29 20:56:55 +00:00

[PR #1404] Bump step-security/harden-runner from 2.13.2 to 2.13.3 #2013

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1404