starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-23 15:15:35 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[PR #780] Add missing "const" to a couple of kConstants #1408

New Issue
Open
opened 2026-01-29 20:53:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:53:55 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/google/brotli/pull/780

State: closed
Merged: Yes

These showed up in a Chromium audit:
https://bugs.chromium.org/p/chromium/issues/detail?id=747064#c8

Although already effectively const, adding "const" causes the symbols to
be moved into the read-only section of the binary.

**Original Pull Request:** https://github.com/google/brotli/pull/780 **State:** closed **Merged:** Yes --- These showed up in a Chromium audit: https://bugs.chromium.org/p/chromium/issues/detail?id=747064#c8 Although already effectively const, adding "const" causes the symbols to be moved into the read-only section of the binary.
claunia added the pull-request label 2026-01-29 20:53:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#1408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?