starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

Nasty bug in modp_dtoa #141

New Issue
Open
opened 2026-01-29 20:38:22 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:38:22 +00:00
Owner
Copy Link

Originally created by @jeroen on GitHub (Sep 21, 2016).

I got bitten by a this long standing bug in modp_dtoa{,2,3}: https://github.com/client9/stringencoders/issues/40. I was able to reproduce it with brotli as well.

The following values should rond to 1.0 but instead return 0.1

modp_dtoa(0.95, str, 1); 
modp_dtoa(0.9999995, str, 6);

Unfortunately upstream does not seem to be maintained anymore.

Originally created by @jeroen on GitHub (Sep 21, 2016). I got bitten by a this long standing bug in `modp_dtoa{,2,3}`: https://github.com/client9/stringencoders/issues/40. I was able to reproduce it with brotli as well. The following values should rond to `1.0` but instead return `0.1` ``` c modp_dtoa(0.95, str, 1); modp_dtoa(0.9999995, str, 6); ``` Unfortunately upstream does not seem to be maintained anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#141
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?