[PR #843] [MERGED] Fix VC C++ 12.0 BROTLI_MSVC_VERSION_CHECK calls #1441

New Issue

claunia · 2026-01-29T20:54:08Z

claunia commented

2026-01-29 20:54:08 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/843
Author: @gpotter2
Created: 9/16/2020
Status: ✅ Merged
Merged: 9/21/2020
Merged by: @eustas

Base: master ← Head: master

📝 Commits (1)

a2ea594 Fix VC C++ 12.0 BROTLI_MSVC_VERSION_CHECK calls

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 c/common/platform.h (+3 -3)

📄 Description

fix https://github.com/google/brotli/issues/837

I was able to try it out locally on Python 2.7 with VC C++ 9.0. This did fix the issue. If possible, it would be nice to have a new version available on PyPy as soon as possible, since 1.0.7 suffers from CVEs.

I really wonder why this wasn't triggered by your test base.

Environment: BUILD_SYSTEM=Python, PYTHON=C:\Python27, PYTHON_VERSION=2.7.x, PYTHON_ARCH=32

fits the description :/

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/843 **Author:** [@gpotter2](https://github.com/gpotter2) **Created:** 9/16/2020 **Status:** ✅ Merged **Merged:** 9/21/2020 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`a2ea594`](https://github.com/google/brotli/commit/a2ea59405808a8f8526cd3e407068e8d994ca340) Fix VC C++ 12.0 BROTLI_MSVC_VERSION_CHECK calls ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `c/common/platform.h` (+3 -3) </details> ### 📄 Description fix https://github.com/google/brotli/issues/837 I was able to try it out locally on Python 2.7 with VC C++ 9.0. This did fix the issue. If possible, it would be nice to have a new version available on PyPy as soon as possible, since 1.0.7 suffers from CVEs. I really wonder why this wasn't triggered by your test base. ``` Environment: BUILD_SYSTEM=Python, PYTHON=C:\Python27, PYTHON_VERSION=2.7.x, PYTHON_ARCH=32 ``` fits the description :/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:54:08 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1441