[PR #843] Fix VC C++ 12.0 BROTLI_MSVC_VERSION_CHECK calls #1446

New Issue

claunia · 2026-01-29T20:54:09Z

claunia commented

2026-01-29 20:54:09 +00:00

Original Pull Request: https://github.com/google/brotli/pull/843

State: closed
Merged: Yes

fix https://github.com/google/brotli/issues/837

I was able to try it out locally on Python 2.7 with VC C++ 9.0. This did fix the issue. If possible, it would be nice to have a new version available on PyPy as soon as possible, since 1.0.7 suffers from CVEs.

I really wonder why this wasn't triggered by your test base.

Environment: BUILD_SYSTEM=Python, PYTHON=C:\Python27, PYTHON_VERSION=2.7.x, PYTHON_ARCH=32

fits the description :/

**Original Pull Request:** https://github.com/google/brotli/pull/843 **State:** closed **Merged:** Yes --- fix https://github.com/google/brotli/issues/837 I was able to try it out locally on Python 2.7 with VC C++ 9.0. This did fix the issue. If possible, it would be nice to have a new version available on PyPy as soon as possible, since 1.0.7 suffers from CVEs. I really wonder why this wasn't triggered by your test base. ``` Environment: BUILD_SYSTEM=Python, PYTHON=C:\Python27, PYTHON_VERSION=2.7.x, PYTHON_ARCH=32 ``` fits the description :/

claunia added the pull-request label 2026-01-29 20:54:09 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1446