[PR #909] [CLOSED] Update buffer parameter types in encode and decode functions #1482

New Issue

claunia · 2026-01-29T20:54:21Z

claunia commented

2026-01-29 20:54:21 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/909
Author: @admiyo
Created: 6/22/2021
Status: ❌ Closed

Base: master ← Head: func-types

📝 Commits (1)

6d66b68 Update buffer parameter types in encode and decode functions

📊 Changes

2 files changed (+11 additions, -6 deletions)

View changed files

📝 c/dec/decode.c (+6 -3)
📝 c/enc/encode.c (+5 -3)

📄 Description

brotil is used in the TianoCore project as a a git submodule. Without this change, the compile fails on Fedora 34 with errors like
brotli/c/dec/decode.c:2033:41: error: argument 2 of type ‘const uint8_t ’ {aka ‘const unsigned char ’} declared as a pointer [-Werror=vla-parameter]
2033 | size_t encoded_size, const uint8_t encoded_buffer, size_t decoded_size,

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/909 **Author:** [@admiyo](https://github.com/admiyo) **Created:** 6/22/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `func-types` --- ### 📝 Commits (1) - [`6d66b68`](https://github.com/google/brotli/commit/6d66b68d9cc69891447119cbb22d2091c611285b) Update buffer parameter types in encode and decode functions ### 📊 Changes **2 files changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `c/dec/decode.c` (+6 -3) 📝 `c/enc/encode.c` (+5 -3) </details> ### 📄 Description brotil is used in the TianoCore project as a a git submodule. Without this change, the compile fails on Fedora 34 with errors like brotli/c/dec/decode.c:2033:41: error: argument 2 of type ‘const uint8_t *’ {aka ‘const unsigned char *’} declared as a pointer [-Werror=vla-parameter] 2033 | size_t encoded_size, const uint8_t* encoded_buffer, size_t* decoded_size, --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:54:21 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1482