[PR #966] Wrap interface include directories with BUILD_INTERFACE generator expression #1527

New Issue

claunia · 2026-01-29T20:54:32Z

claunia commented

2026-01-29 20:54:32 +00:00

Original Pull Request: https://github.com/google/brotli/pull/966

State: closed
Merged: Yes

When exporting a CMake target using install(TARGETS) + install(EXPORT),
CMake requires all include directories to be clean of build system
directories.

https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_INCLUDE_DIRECTORIES.html

This change also allows use of brotli as a CMake subproject and
installing + exporting it.

Needed for https://github.com/libsdl-org/SDL_image/pull/189 (brotli is a dependency of libjxl)

**Original Pull Request:** https://github.com/google/brotli/pull/966 **State:** closed **Merged:** Yes --- When exporting a CMake target using install(TARGETS) + install(EXPORT), CMake requires all include directories to be clean of build system directories. https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_INCLUDE_DIRECTORIES.html This change also allows use of brotli as a CMake subproject and installing + exporting it. Needed for https://github.com/libsdl-org/SDL_image/pull/189 (brotli is a dependency of libjxl)

claunia added the pull-request label 2026-01-29 20:54:32 +00:00

claunia closed this issue

2026-01-29 20:54:32 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1527