[PR #988] [MERGED] CMake: ensure static libraries are still installed on Emscripten #1542

New Issue

claunia · 2026-01-29T20:54:36Z

claunia commented

2026-01-29 20:54:36 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/988
Author: @kleisauke
Created: 12/18/2022
Status: ✅ Merged
Merged: 12/20/2022
Merged by: @eustas

Base: master ← Head: install-static-wasm

📝 Commits (1)

00a73e2 CMake: ensure static libraries are still installed on Emscripten

📊 Changes

1 file changed (+6 additions, -8 deletions)

View changed files

📝 CMakeLists.txt (+6 -8)

📄 Description

Similar to commit ce222e317e.

Context:
https://github.com/google/brotli/pull/655#issuecomment-1353141509

FWIW, the OSS-Fuzz build of Brotli seems to fail.
https://oss-fuzz-build-logs.storage.googleapis.com/index.html#brotli

Let me know if you want a PR for that too (a trivial change, since that build script was probably based on c/fuzz/test_fuzzer.sh)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/988 **Author:** [@kleisauke](https://github.com/kleisauke) **Created:** 12/18/2022 **Status:** ✅ Merged **Merged:** 12/20/2022 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `install-static-wasm` --- ### 📝 Commits (1) - [`00a73e2`](https://github.com/google/brotli/commit/00a73e2a9c5242474207336a26aadb1b0e5ecb5e) CMake: ensure static libraries are still installed on Emscripten ### 📊 Changes **1 file changed** (+6 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+6 -8) </details> ### 📄 Description Similar to commit ce222e317e36aa362e83fc50c7a6226d238e03fd. --- Context: https://github.com/google/brotli/pull/655#issuecomment-1353141509 FWIW, the OSS-Fuzz build of Brotli seems to fail. https://oss-fuzz-build-logs.storage.googleapis.com/index.html#brotli Let me know if you want a PR for that too (a trivial change, since that build script was probably based on `c/fuzz/test_fuzzer.sh`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:54:36 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1542