mirror of
https://github.com/google/brotli.git
synced 2026-07-08 17:56:58 +00:00
pre-compiled wheels for linux? #157
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anthrotype on GitHub (Feb 9, 2017).
The python bindings are currently provided as wheel packages on Github and PyPI, but only for macOS and Windows, and for python2.7, 3.4, and 3.5. For other platforms like Linux, a source distribution is provided, but this of course requires users to have a C compiler.
I would like to help setting up Travis CI to also build
manylinux1wheels which are portable across most Linux distributions.I've done this for several other projects using
multibuild, a set of shell scripts originally developed for the Python scientific stack (numpy, scipy, etc.), which makes super easy to set up Travis/Appveyor as wheel builders for Linux, macOS and Windows.Before I proceed working on a pull request, I first wanted to gauge interest and ask for comments.
We have two options:
add
multibuildto thegoogle/brotlirepo and configure Travis with additional jobs to also build the Linux wheels.create a separate
google/brotli-wheelsrepository with its own Travis/Appveyor CI configuration, which would clone the upstream repo as a git submodule, and would only trigger new builds when the submodule is manually updated, e.g. before a new release.The latter is also the approach recommended in multibuild's README, and used by projects like https://github.com/MacPython/numpy-wheels, https://github.com/MacPython/matplotlib-wheels
and others.
I'd tend to opt for the second approach, because I see that brotli's Travis matrix is already quite crowded, and adding support for manylinux1 would add at least 8 new jobs (4 jobs cover all the python2.7, 32 vs 64 bit, "narrow" vs "wide" unicode build; plus 4 more to cover 3.5 and 3.6, 32 and 64 bit), thus further slowing it down.
What do you think?
@anthrotype commented on GitHub (Mar 1, 2017):
ping @szabadka
I can volunteer to maintain this
brotli-wheelsrepository, and set it up to build wheels when the upstreambrotliis released, and have it upload them automatically to PyPI.I could create the new repository under my Github username, or if you wish, you can create it under the
googleGithub organization and add me as collaborator for that repo.I would also require access to the
brotliPyPI account.@szabadka commented on GitHub (Mar 1, 2017):
Having a separate brotli-wheels looks like a good solution for this. How
can I give access to the brotli PyPI account?
On Wed, Mar 1, 2017 at 1:55 PM, Cosimo Lupo notifications@github.com
wrote:
@eustas commented on GitHub (Mar 1, 2017):
Hello. Sorry, this request has fallen out of my view.
I'll give access to PyPI account soon.
@anthrotype commented on GitHub (Mar 1, 2017):
you need to add me as collaborator in the "roles" section on the brotli PyPI page:
https://pypi.python.org/pypi?:action=role_form&package_name=brotli
My pypi username is also
anthrotype.@eustas commented on GitHub (Mar 1, 2017):
Going to investigate what bureaucracy needs to be done to create google/brotli-wheels repo.
@anthrotype commented on GitHub (Mar 1, 2017):
Thank you!
@eustas commented on GitHub (Mar 10, 2017):
Woohoo, https://github.com/google/brotli-wheels has arrived =)
@anthrotype commented on GitHub (Mar 10, 2017):
thanks @eustas! 👍
I won't be able to work on that before next week.
@eustas commented on GitHub (Mar 10, 2017):
No worries =)
@eustas commented on GitHub (Sep 19, 2017):
Any updates?