[PR #1143] [CLOSED] Don't check cur_ix_masked against ring_buffer_mask. #1701

New Issue

claunia · 2026-01-29T20:55:24Z

claunia commented

2026-01-29 20:55:24 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1143
Author: @copybara-service[bot]
Created: 3/17/2024
Status: ❌ Closed

Base: master ← Head: test_616440826

📄 Description

Don't check cur_ix_masked against ring_buffer_mask.

cur_ix_masked isn't changing from iteration to iteration, and max_length ensures we never find a match long enough to walk off the ring buffer.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1143 **Author:** [@copybara-service[bot]](https://github.com/apps/copybara-service) **Created:** 3/17/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `test_616440826` --- ### 📄 Description Don't check `cur_ix_masked` against `ring_buffer_mask`. `cur_ix_masked` isn't changing from iteration to iteration, and `max_length` ensures we never find a match long enough to walk off the ring buffer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:55:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1701

[PR #1143] [CLOSED] Don't check cur_ix_masked against ring_buffer_mask. #1701

📋 Pull Request Information

📄 Description

[PR #1143] [CLOSED] Don't check `cur_ix_masked` against `ring_buffer_mask`. #1701