[PR #1185] [MERGED] cbrotli: add pkg-config directive #1752

New Issue

claunia · 2026-01-29T20:55:37Z

claunia commented

2026-01-29 20:55:37 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1185
Author: @dloebl
Created: 8/7/2024
Status: ✅ Merged
Merged: 11/20/2024
Merged by: @copybara-service[bot]

Base: master ← Head: cbrotli-add-pkg-config-directive

📝 Commits (1)

90833a8 cbrotli: add pkg-config directive

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 go/cbrotli/cgo.go (+1 -3)

📄 Description

Adds the pkg-config directive for libbrotlicommon, libbrotlidec and libbrotlienc. Without this change, building cbrotli may fail on some platforms because the include directories are not set correctly:

github.com/google/brotli/go/cbrotli
# github.com/google/brotli/go/cbrotli
vendor/github.com/google/brotli/go/cbrotli/reader.go:13:10: fatal error: 'brotli/decode.h' file not found
#include <brotli/decode.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1185 **Author:** [@dloebl](https://github.com/dloebl) **Created:** 8/7/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@copybara-service[bot]](https://github.com/apps/copybara-service) **Base:** `master` ← **Head:** `cbrotli-add-pkg-config-directive` --- ### 📝 Commits (1) - [`90833a8`](https://github.com/google/brotli/commit/90833a88cde5c78dcfcc51aacef2fb29f0403c72) cbrotli: add pkg-config directive ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `go/cbrotli/cgo.go` (+1 -3) </details> ### 📄 Description Adds the pkg-config directive for `libbrotlicommon`, `libbrotlidec` and `libbrotlienc`. Without this change, building `cbrotli` may fail on some platforms because the include directories are not set correctly: ``` github.com/google/brotli/go/cbrotli # github.com/google/brotli/go/cbrotli vendor/github.com/google/brotli/go/cbrotli/reader.go:13:10: fatal error: 'brotli/decode.h' file not found #include <brotli/decode.h> ^~~~~~~~~~~~~~~~~ 1 error generated. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:55:37 +00:00

claunia closed this issue

2026-01-29 20:55:38 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1752