[PR #1205] [CLOSED] python - link statically against vc_redist #1765

New Issue

claunia · 2026-01-29T20:55:42Z

claunia commented

2026-01-29 20:55:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1205
Author: @K0lb3
Created: 10/5/2024
Status: ❌ Closed

Base: master ← Head: python---link-statically-against-vc_redist

📝 Commits (1)

5938469 python - link statically against vc_redist

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 setup.py (+6 -0)

📄 Description

This PR makes the python setup link against vc_runtime statically if msvc is used as compiler.
As cibuildwheel uses msvc on Windows, this PR solves #782 for good.
#782 is still an active issue and was closed despite it not being solved,
besides basically forcing all dependents to have to write about Windows users having to vc_redist.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1205 **Author:** [@K0lb3](https://github.com/K0lb3) **Created:** 10/5/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `python---link-statically-against-vc_redist` --- ### 📝 Commits (1) - [`5938469`](https://github.com/google/brotli/commit/593846984eb1a574d8039e2c8b26a2fc125950ba) python - link statically against vc_redist ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `setup.py` (+6 -0) </details> ### 📄 Description This PR makes the python setup link against vc_runtime statically if msvc is used as compiler. As cibuildwheel uses msvc on Windows, this PR solves #782 for good. #782 is still an active issue and was closed despite it not being solved, besides basically forcing all dependents to have to write about Windows users having to vc_redist. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:55:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1765