[PR #1240] [MERGED] Update bro.py: Fix undefined name in Python code #1808

New Issue

claunia · 2026-01-29T20:55:54Z

claunia commented

2026-01-29 20:55:54 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1240
Author: @cclauss
Created: 1/9/2025
Status: ✅ Merged
Merged: 5/27/2025
Merged by: @eustas

Base: master ← Head: patch-1

📝 Commits (2)

0ffb940 Update bro.py: Fix undefined name in Python code
0caff5e Merge branch 'master' into patch-1

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 python/bro.py (+1 -1)

📄 Description

outfile is used before it is defined on the following line so instead use options.outfile as is done two lines above. Without this modification, NameError could be raised at runtime.

% ruff check

Error: python/bro.py:168:64: F821 Undefined name `outfile`

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1240 **Author:** [@cclauss](https://github.com/cclauss) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 5/27/2025 **Merged by:** [@eustas](https://github.com/eustas) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`0ffb940`](https://github.com/google/brotli/commit/0ffb940747ce03ee92bc9bceb81e9953bf3b6913) Update bro.py: Fix undefined name in Python code - [`0caff5e`](https://github.com/google/brotli/commit/0caff5e1b80aabf418860147765ccc66c3a11e08) Merge branch 'master' into patch-1 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `python/bro.py` (+1 -1) </details> ### 📄 Description `outfile` is used before it is defined on the following line so instead use `options.outfile` as is done two lines above. Without this modification, `NameError` could be raised at runtime. % [`ruff check`](https://docs.astral.sh/ruff) ``` Error: python/bro.py:168:64: F821 Undefined name `outfile` ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:55:54 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1808