[PR #1257] [MERGED] enabled support to python 3.12 per GIL interpeter using multi-phase module inizialization #1829

New Issue

claunia · 2026-01-29T20:56:00Z

claunia commented

2026-01-29 20:56:00 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1257
Author: @domysh
Created: 3/15/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @copybara-service[bot]

Base: master ← Head: master

📝 Commits (9)

c710db0 enabled support to 3.12 per GIL interpeter using multistage module inizialization
e45f18c DECREF on exception raise
998a28b using module state for error handling
ddb803a using static function
964ca07 fix module import in set exception + setup.py compatible with python2
79ea729 Merge branch 'master' into master
8fea9e3 Merge branch 'master' into master
4473857 Update setup.py
0903aad Update setup.py

📊 Changes

2 files changed (+295 additions, -213 deletions)

View changed files

📝 python/_brotli.c (+133 -53)
📝 setup.py (+162 -160)

📄 Description

The project was already correctly ready to works with multiple interpeters and also with per interpeter GIL https://peps.python.org/pep-0684/, but the module was not inizialized in multi-phase making it unusable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1257 **Author:** [@domysh](https://github.com/domysh) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@copybara-service[bot]](https://github.com/apps/copybara-service) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`c710db0`](https://github.com/google/brotli/commit/c710db05107bb8ec68aeb4c992a34ec876046400) enabled support to 3.12 per GIL interpeter using multistage module inizialization - [`e45f18c`](https://github.com/google/brotli/commit/e45f18ccca59b96d96526ccf48540e14d818dac9) DECREF on exception raise - [`998a28b`](https://github.com/google/brotli/commit/998a28bde4666593c4acc41301c470be6eb350d6) using module state for error handling - [`ddb803a`](https://github.com/google/brotli/commit/ddb803acc3f430635d63a8cadd9b725ce059f655) using static function - [`964ca07`](https://github.com/google/brotli/commit/964ca075d1e7cafadf98ddf1b62e0ac4be33f0c7) fix module import in set exception + setup.py compatible with python2 - [`79ea729`](https://github.com/google/brotli/commit/79ea7296d4fb81401f658ad793b30367ceca5f40) Merge branch 'master' into master - [`8fea9e3`](https://github.com/google/brotli/commit/8fea9e31c884eb478700c0ec35e5373d652d13e6) Merge branch 'master' into master - [`4473857`](https://github.com/google/brotli/commit/447385795fda80aa0915063729b01fe1c0e76b83) Update setup.py - [`0903aad`](https://github.com/google/brotli/commit/0903aad0d7dbf8e4d9ea77e73cbd1e0c82c49dd2) Update setup.py ### 📊 Changes **2 files changed** (+295 additions, -213 deletions) <details> <summary>View changed files</summary> 📝 `python/_brotli.c` (+133 -53) 📝 `setup.py` (+162 -160) </details> ### 📄 Description The project was already correctly ready to works with multiple interpeters and also with per interpeter GIL https://peps.python.org/pep-0684/, but the module was not inizialized in multi-phase making it unusable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:56:00 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1829