[PR #1367] [CLOSED] cmake: fix man page install directories #1972

New Issue

claunia · 2026-01-29T20:56:44Z

claunia commented

2026-01-29 20:56:44 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1367
Author: @vszakats
Created: 10/27/2025
Status: ❌ Closed

Base: master ← Head: cmman

📝 Commits (1)

5968a5a cmake: fix man page install directories

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)

📄 Description

To not use a prefix-less absolute path with
cmake --install <d> --prefix <path>.

According to CMake docs about _FULL_ variables:
"These variables shouldn't be used in install() commands as they do
not work with the cmake --install command's --prefix option, or with
the cpack installer generators."

Ref: https://cmake.org/cmake/help/v4.2/module/GNUInstallDirs.html

Follow-up to cff5803216 #1084

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1367 **Author:** [@vszakats](https://github.com/vszakats) **Created:** 10/27/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cmman` --- ### 📝 Commits (1) - [`5968a5a`](https://github.com/google/brotli/commit/5968a5a84edc75088e76586a8860390cbf8955c7) cmake: fix man page install directories ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) </details> ### 📄 Description To not use a prefix-less absolute path with `cmake --install <d> --prefix <path>`. According to CMake docs about `_FULL_` variables: "These variables shouldn't be used in install() commands as they do not work with the cmake --install command's --prefix option, or with the cpack installer generators." Ref: https://cmake.org/cmake/help/v4.2/module/GNUInstallDirs.html Follow-up to cff58032160406c170a3dc319ad6e7b288cafcc0 #1084 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:56:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1972